Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perfstress] Multiprocess support #22997

Merged
merged 21 commits into from
Dec 18, 2022
Merged

Conversation

annatisch
Copy link
Member

@annatisch annatisch commented Feb 9, 2022

Fixes #16121

@check-enforcer
Copy link

check-enforcer bot commented Feb 9, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@annatisch annatisch requested a review from mikeharder February 14, 2022 22:31
@mikeharder
Copy link
Member

mikeharder commented Apr 26, 2022

Issue that can be fixed after this PR is merged:

#24194 [Perf] Invalid intermediate results when using multiple processes

@mikeharder mikeharder self-assigned this Jul 2, 2022
@mikeharder mikeharder added the pillar-performance The issue is related to performance, one of our core engineering pillars. label Jul 2, 2022
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Sep 2, 2022
@ghost
Copy link

ghost commented Sep 2, 2022

Hi @annatisch. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label Sep 4, 2022
@annatisch annatisch marked this pull request as ready for review September 4, 2022 19:44
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Dec 2, 2022
@ghost
Copy link

ghost commented Dec 2, 2022

Hi @annatisch. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@mikeharder
Copy link
Member

Ping to keep PR alive

@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label Dec 6, 2022
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Definitely noticed a great improvement in Python performance numbers now that cores are utlized. I left some comments inline.

Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the updated docs are quite helpful! Only a few minor typos.

Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like cspell has more complaints:

##[error]./doc/dev/perfstress_tests.md:4:33 - Unknown word (perfstresstest)
##[error]./doc/dev/perfstress_tests.md:5:32 - Unknown word (batchperftest)
##[error]./doc/dev/perfstress_tests.md:124:15 - Unknown word (cumultive)
##[error]./doc/dev/perfstress_tests.md:129:15 - Unknown word (cumultive)
##[error]./doc/dev/perfstress_tests.md:161:20 - Unknown word (sychronous)
##[error]./doc/dev/perfstress_tests.md:168:20 - Unknown word (asychronous)
##[error]./doc/dev/perfstress_tests.md:256:27 - Unknown word (ancilliary)
##[error]./doc/dev/perfstress_tests.md:266:27 - Unknown word (ancilliary)
##[error]./doc/dev/perfstress_tests.md:292:32 - Unknown word (streamperftests)

s/ancilliary/ancillary
Then I suppose we can just hyphenate the example container name to make cspell happy: s/streamperftests/stream-perf-tests

annatisch and others added 3 commits December 16, 2022 16:01
Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>
@annatisch annatisch merged commit 3b125e3 into Azure:main Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pillar-performance The issue is related to performance, one of our core engineering pillars.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Perf] Add option to use multiple processes
3 participants