Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[textanalytics] switch to kwargs where we run nonrecorded tests #22614

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

kristapratico
Copy link
Member

@kristapratico kristapratico commented Jan 21, 2022

If we don't want to record a test, we omit the @recorded_by_proxy decorator. However, this decorator allows the test params be passed as actual params, whereas in its absence, pytest treats any params as fixtures. Moving test params to kwargs for unrecorded tests fixes the issue. Thanks @mccoyp for the help!

@kristapratico kristapratico merged commit 895dc5a into Azure:main Jan 21, 2022
@kristapratico kristapratico deleted the ta-fix-no-record-tests branch January 21, 2022 17:23
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
…e#22614)

* switch to kwargs where we run nonrecorded tests

* remove unused import
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Feb 16, 2023
mediaservices microsoft.media 2023 01 01: Add Minimum TLS Version property (Azure#22614)

* Adds base for updating Microsoft.Media/Accounts from version stable/2021-11-01 to version 2023-01-01

* Updates readme

* Updates API version in new specs and examples

* add tls version

* add default

* add to readme test

* fix readme

---------

Co-authored-by: Sea Eun Lee <seaeunlee@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants