Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the printing message. #22301

Merged
merged 11 commits into from
Jan 6, 2022
Merged

Fixed the printing message. #22301

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4a3b2a5
Fixed the printing message.
sima-zhu Jan 3, 2022
dc0adae
add variable
sima-zhu Jan 3, 2022
aa340f7
initiate the message.
sima-zhu Jan 3, 2022
5fcc028
for debugging
sima-zhu Jan 3, 2022
6886cd4
Update Language-Settings.ps1
sima-zhu Jan 5, 2022
e982f3c
Update Language-Settings.ps1
sima-zhu Jan 5, 2022
e0591cd
Update Language-Settings.ps1
sima-zhu Jan 5, 2022
9857609
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
sima-zhu Jan 5, 2022
44e4401
Update Language-Settings.ps1
sima-zhu Jan 5, 2022
1105789
Update eng/scripts/Language-Settings.ps1
sima-zhu Jan 6, 2022
25740a2
Update eng/scripts/Language-Settings.ps1
sima-zhu Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions eng/scripts/Language-Settings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,24 +204,25 @@ function DockerValidation{
[string]$workingDirectory
)
if ($PackageSourceOverride) {
docker run -v "${workingDirectory}:/workdir/out" -e TARGET_PACKAGE=$packageName -e TARGET_VERSION=$packageVersion `
$commandLine = docker run -v "${workingDirectory}:/workdir/out" -e TARGET_PACKAGE=$packageName -e TARGET_VERSION=$packageVersion `
-e EXTRA_INDEX_URL=$PackageSourceOverride -t $DocValidationImageId 2>&1 | Out-Null
}
else {
docker run -v "${workingDirectory}:/workdir/out" `
$commandLine = docker run -v "${workingDirectory}:/workdir/out" `
-e TARGET_PACKAGE=$packageName -e TARGET_VERSION=$packageVersion -t $DocValidationImageId 2>&1 | Out-Null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to remove the Out-Null here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. That's for testing purpose.
I am kicking a pipeline.
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1276768&view=results

}
# The docker exit codes: https://docs.docker.com/engine/reference/run/#exit-status
# If the docker failed because of docker itself instead of the application,
# we should skip the validation and keep the packages.

if ($LASTEXITCODE -eq 125 -Or $LASTEXITCODE -eq 126 -Or $LASTEXITCODE -eq 127) {
Write-Host $commandLine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is always going to be empty because you are piping to Out-Null. You should remove the null pipe if you're capturing it in a variable to be printed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put the message to debug level. Then, we can rerun the pipeline by turn on 'System.debug'

LogWarning "The `docker` command does not work with exit code $LASTEXITCODE. Fall back to npm install $packageName directly."
FallbackValidation -packageName "$packageName" -packageVersion "$packageVersion" -workingDirectory $workingDirectory -PackageSourceOverride $PackageSourceOverride
}
elseif ($LASTEXITCODE -ne 0) {
Write-Host $commandLine
LogWarning "Package $($Package.name) ref docs validation failed."
LogWarning "Package $packageName ref docs validation failed."
return $false
}
return $true
Expand Down