-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credentials accept tenant_id argument to get_token #19602
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
7998ad7
GetTokenMixin passes kwargs through the get_token flow
chlowell d57b93b
credentials using MSAL take tenant_id in get_token
chlowell e5f2502
AadClient allows multitenant auth
chlowell df6c707
remove some dead code
chlowell 1b90fdb
async service principal credentials accept tenant_id for silent auth
chlowell f8238c2
so does VisualStudioCodeCredential
chlowell a4fdaa2
auth code and CLI credentials
chlowell 6a3e8b8
PowerShell credential
chlowell 1d286c9
SharedTokenCacheCredential
chlowell 8e90d26
tests
chlowell ae143bf
Thanks, McCoy
chlowell a027eb4
MsalCredential isn't abstract anymore
chlowell 9122191
keyword-only syntax
chlowell 7781b76
try %WINDIR% after %SYSTEMROOT%
chlowell 3424c88
rather, stop clearing environ in these tests 😂
chlowell f726cd3
actually these credentials should tolerate unexpected kwargs
chlowell 3298bb2
add allow_multitenant_authentication to DefaultAzureCredential
chlowell f0ab7b2
tests
chlowell fa7bac0
update docstrings
chlowell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
actually these credentials should tolerate unexpected kwargs
- Loading branch information
commit f726cd30cef278bcd61cc36daaaab018298d7926
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we
kwargs.pop
here and in the sync version?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need,
kwargs
isn't used again. I should use keyword-only syntax here though.