Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credentials accept tenant_id argument to get_token #19602

Merged
merged 19 commits into from
Jul 8, 2021
Merged

Credentials accept tenant_id argument to get_token #19602

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7998ad7
GetTokenMixin passes kwargs through the get_token flow
chlowell Jun 25, 2021
d57b93b
credentials using MSAL take tenant_id in get_token
chlowell Jun 25, 2021
e5f2502
AadClient allows multitenant auth
chlowell Jun 28, 2021
df6c707
remove some dead code
chlowell Jun 28, 2021
1b90fdb
async service principal credentials accept tenant_id for silent auth
chlowell Jun 28, 2021
f8238c2
so does VisualStudioCodeCredential
chlowell Jun 29, 2021
a4fdaa2
auth code and CLI credentials
chlowell Jun 30, 2021
6a3e8b8
PowerShell credential
chlowell Jun 30, 2021
1d286c9
SharedTokenCacheCredential
chlowell Jul 1, 2021
8e90d26
tests
chlowell Jun 29, 2021
ae143bf
Thanks, McCoy
chlowell Jul 6, 2021
a027eb4
MsalCredential isn't abstract anymore
chlowell Jul 6, 2021
9122191
keyword-only syntax
chlowell Jul 6, 2021
7781b76
try %WINDIR% after %SYSTEMROOT%
chlowell Jul 7, 2021
3424c88
rather, stop clearing environ in these tests 😂
chlowell Jul 7, 2021
f726cd3
actually these credentials should tolerate unexpected kwargs
chlowell Jul 7, 2021
3298bb2
add allow_multitenant_authentication to DefaultAzureCredential
chlowell Jul 7, 2021
f0ab7b2
tests
chlowell Jul 7, 2021
fa7bac0
update docstrings
chlowell Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
actually these credentials should tolerate unexpected kwargs
  • Loading branch information
@chlowell
chlowell committed Jul 7, 2021
commit f726cd30cef278bcd61cc36daaaab018298d7926
4 changes: 2 additions & 2 deletions sdk/identity/azure-identity/azure/identity/aio/_credentials/azure_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ class AzureCliCredential(AsyncContextManager):
acquire tokens only from the tenant of the Azure CLI's active subscription.
"""

def __init__(self, *, allow_multitenant_authentication=False) -> None:
self._allow_multitenant = allow_multitenant_authentication
def __init__(self, **kwargs: "Any") -> None:
self._allow_multitenant = kwargs.get("allow_multitenant_authentication", False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we kwargs.pop here and in the sync version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, kwargs isn't used again. I should use keyword-only syntax here though.


@log_get_token_async
async def get_token(self, *scopes: str, **kwargs: "Any") -> "AccessToken":
Expand Down
4 changes: 2 additions & 2 deletions sdk/identity/azure-identity/azure/identity/aio/_credentials/azure_powershell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ class AzurePowerShellCredential(AsyncContextManager):
will acquire tokens only from the tenant of Azure PowerShell's active subscription.
"""

def __init__(self, *, allow_multitenant_authentication=False) -> None:
self._allow_multitenant = allow_multitenant_authentication
def __init__(self, **kwargs: "Any") -> None:
self._allow_multitenant = kwargs.get("allow_multitenant_authentication", False)

@log_get_token_async
async def get_token(
Expand Down