Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translation] unskip tests now that correct error status is returned #19090

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

kristapratico
Copy link
Member

Resolves #17914

This was previously returning "Failed" for a bad target URL, but the service has fixed it to correctly return "ValidationFailed' in v1.0. Also looks like they updated the error code to be more explicit.

@maririos
Copy link
Member

maririos commented Jun 3, 2021

Thanks for verifying. I need to do the same in .NET

@kristapratico kristapratico merged commit 4454621 into Azure:master Jun 3, 2021
@kristapratico kristapratico deleted the unskip-dt-tests branch June 3, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[translation] bad target URL input is returning "Failed" instead of "ValidationFailed"
3 participants