Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment variable for redirecting IMDS token requests #18967

Merged
merged 4 commits into from
Jun 3, 2021
Merged

Add environment variable for redirecting IMDS token requests #18967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d4107f
ImdsCredential reads AZURE_IMDS_TOKEN_URL
chlowell May 21, 2021
3214f7f
add tests
chlowell May 21, 2021
f318859
correct tests
chlowell Jun 1, 2021
d201d96
AZURE_IMDS_TOKEN_URL -> AZURE_POD_IDENTITY_TOKEN_URL
chlowell Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
correct tests
  • Loading branch information
@chlowell
chlowell committed Jun 1, 2021
commit f318859b2bae0f31dc877b4285c558a6f254b5ff
4 changes: 1 addition & 3 deletions sdk/identity/azure-identity/tests/test_imds_credential.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ def test_imds_url_override():

transport = validating_transport(
requests=[
Request(base_url=url),
Request(
base_url=url,
method="GET",
Expand All @@ -194,7 +193,6 @@ def test_imds_url_override():
),
],
responses=[
mock_response(status_code=400, json_payload={"error": "this is an error message"}),
mock_response(
json_payload={
"access_token": expected_token,
Expand All @@ -209,8 +207,8 @@ def test_imds_url_override():
],
)

credential = ImdsCredential(transport=transport)
with mock.patch.dict("os.environ", {EnvironmentVariables.AZURE_IMDS_TOKEN_URL: url}, clear=True):
credential = ImdsCredential(transport=transport)
token = credential.get_token(scope)

assert token.token == expected_token
Expand Down
4 changes: 1 addition & 3 deletions sdk/identity/azure-identity/tests/test_imds_credential_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ async def test_imds_url_override():

transport = async_validating_transport(
requests=[
Request(base_url=url),
Request(
base_url=url,
method="GET",
Expand All @@ -229,7 +228,6 @@ async def test_imds_url_override():
),
],
responses=[
mock_response(status_code=400, json_payload={"error": "this is an error message"}),
mock_response(
json_payload={
"access_token": expected_token,
Expand All @@ -244,8 +242,8 @@ async def test_imds_url_override():
],
)

credential = ImdsCredential(transport=transport)
with mock.patch.dict("os.environ", {EnvironmentVariables.AZURE_IMDS_TOKEN_URL: url}, clear=True):
credential = ImdsCredential(transport=transport)
token = await credential.get_token(scope)

assert token.token == expected_token
Expand Down