[translation] regenerate on v1.0 #18861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run python - translation - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maririos
reviewed
May 24, 2021
| @@ -11,7 +11,7 @@ | |||
| from azure.core.credentials import AzureKeyCredential | |||
| from azure.core.pipeline.policies import AzureKeyCredentialPolicy | |||
| from ._generated import BatchDocumentTranslationClient as _BatchDocumentTranslationClient | |||
| from ._generated.models import BatchStatusDetail as _BatchStatusDetail | |||
| from ._generated.models import TranslationStatus as _TranslationStatus | |||
There was a problem hiding this comment.
this is because of the swagger update, right? did you change any public api ? not sure how I can see that :(
There was a problem hiding this comment.
This is updated due to the renames in the swagger. No public API changes.
| @@ -125,7 +125,7 @@ def test_list_submitted_jobs_filter_by_created_after(self, client): | |||
| docs_per_job = 2 | |||
|
|
|||
| # create some jobs | |||
| start = datetime.now() | |||
| start = datetime.utcnow() | |||
There was a problem hiding this comment.
This is in the tests, so not an SDK bug. Just an adjustment so that these tests pass for whatever timezone you are running it in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18778
Regenerates on the v1.0 swagger and rerecords all tests.