-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[translation] regenerate on v1.0 #18861
Conversation
/azp run python - translation - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -11,7 +11,7 @@ | |||
from azure.core.credentials import AzureKeyCredential | |||
from azure.core.pipeline.policies import AzureKeyCredentialPolicy | |||
from ._generated import BatchDocumentTranslationClient as _BatchDocumentTranslationClient | |||
from ._generated.models import BatchStatusDetail as _BatchStatusDetail | |||
from ._generated.models import TranslationStatus as _TranslationStatus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is because of the swagger update, right? did you change any public api ? not sure how I can see that :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is updated due to the renames in the swagger. No public API changes.
@@ -125,7 +125,7 @@ def test_list_submitted_jobs_filter_by_created_after(self, client): | |||
docs_per_job = 2 | |||
|
|||
# create some jobs | |||
start = datetime.now() | |||
start = datetime.utcnow() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this a bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in the tests, so not an SDK bug. Just an adjustment so that these tests pass for whatever timezone you are running it in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog update
Resolves #18778
Regenerates on the v1.0 swagger and rerecords all tests.