Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[formrecognizer] regenerates on v2.1 #18551

Merged
merged 14 commits into from
May 11, 2021
Merged

[formrecognizer] regenerates on v2.1 #18551

merged 14 commits into from
May 11, 2021

Conversation

kristapratico
Copy link
Member

@kristapratico kristapratico commented May 6, 2021

Resolves #18133 #17062 #15276 #18482

Regenerates on v2.1 and sets as default. Note that AAD is not working yet.

@kristapratico kristapratico marked this pull request as ready for review May 11, 2021 03:55
@kristapratico
Copy link
Member Author

/azp run python - formrecognizer - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kristapratico
Copy link
Member Author

/azp run python - formrecognizer - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@danieljurek
Copy link
Member

/azp run python - formrecognizer - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

if country:
print("Country: {} has confidence: {}".format(country.value, country.confidence))
print("Country Region: {} has confidence: {}".format(country.value, country.confidence))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a slash here? Or join the words like the field name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean. Can you post an example?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if Country Region should be Country/Region or CountryRegion? Simply because I skimmed through the docs shared from the service team and I know it is sensitive to how this information is shown.

Ok just checked the doc...I think we should go with Country/Region to make sure we're displaying the information correctly (this is the example I see the guidance following the most)

Copy link
Member

@catalinaperalta catalinaperalta May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly this feels like a nit to me 😅 but just said it since I'm not sure if the space implies something different than the slash...but I may be analyzing this too much.

Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only left my country region nit, but aside from that this looks great. Thanks for doing this!!

@kristapratico kristapratico merged commit 9650c02 into master May 11, 2021
@kristapratico kristapratico deleted the fr2.1 branch May 11, 2021 22:01
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 12, 2021
…into fix_confidentialledger_aiohttp

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  regenerate (Azure#18647)
  [formrecognizer] remove polling interval from doc comments (Azure#18645)
  [formrecognizer] regenerates on v2.1 (Azure#18551)
  adding images to anonymous client (Azure#18646)
  Confidential Ledger: Update README samples and CHANGELOG (Azure#18644)
  [Container Registry] Anonymous Access Client (Azure#18550)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Apr 27, 2022
[Hub Generated] Publish private branch 'dev-orbital-Microsoft.Orbital-2021-04-04-preview' (Azure#18551)

* New Swagger Spec File

* New Swagger Example Spec File

* New Readme Config File

* New Azure AZ Readme Config File

* New Azure CLI Readme Config File

* New Go Language Readme Config File

* New Python Language Readme Config File

* New Typescript Language Readme Config File

* New C# Language Readme Config File

* Orbital sdk 2021 04 04 preview (#5253)

* New Readme Config File

* New Go Language Readme Config File

* New Typescript Language Readme Config File

* New Python Language Readme Config File

* New C# Language Readme Config File

* New Ruby Language Readme Config File

* New Swagger Spec File

* New Swagger Example Spec File

* Added orbital.json file

* Passed linting using AutoRest for 2020-09-01 Azure Orbital Private Privew

* Updated Operation object under Azure Orbital 2020-09-01 preview.

* Updated Operation object under Azure Orbital 2020-09-01 preview.

* Updated Satellites object for Azure Orbital 2020-09-01 preview

* Updated examples for Azure Orbital Private Preview 2020-09-01

* Updated examples for Azure Orbital Private Preview 2020-09-01

* Updated examples for Azure Orbital Private Preview 2020-09-01

* Addressed feedback from ARMChangesRequested

* Updated the GetAvailableContacts api to add long running operation

* Updated the api version

* Updated the objects based on discussion with PM.

* list available ground station made a POST request (#2521)

* list available ground station made a POST request

* Swagger LintDiff fix

Co-authored-by: Devanshu Singh <devasingh@microsoft.com>

* swagger specs for version-20210404-preview

* removed cross version references. Copied over unchanged examples from the previous API version 2021-09-01-preview

* removed availableGroundStations API

* New Readme Config File

New Go Language Readme Config File

New Typescript Language Readme Config File

New Python Language Readme Config File

New C# Language Readme Config File

New Ruby Language Readme Config File

New Swagger Spec File

New Swagger Example Spec File

Added orbital.json file

Passed linting using AutoRest for 2020-09-01 Azure Orbital Private Privew

Updated Operation object under Azure Orbital 2020-09-01 preview.

Updated Operation object under Azure Orbital 2020-09-01 preview.

Updated Satellites object for Azure Orbital 2020-09-01 preview

Updated examples for Azure Orbital Private Preview 2020-09-01

Updated examples for Azure Orbital Private Preview 2020-09-01

Updated examples for Azure Orbital Private Preview 2020-09-01

Addressed feedback from ARMChangesRequested

Updated the GetAvailableContacts api to add long running operation

Updated the api version

Updated the objects based on discussion with PM.

list available ground station made a POST request (#2521)

* list available ground station made a POST request

* Swagger LintDiff fix

Co-authored-by: Devanshu Singh <devasingh@microsoft.com>

* validation check changes. Avocado, SpellCheck and prettier

* validation checks changes

* Modify readme.md for sdk generation

* added system data

* sdk pre namer validation changes

* lintdiff warning changes

* add comms scenario swagger (#3794)

* add comms scenario swagger

* remove unused example

* fix some validation errors

* fix style issues

* update spec based on feedback

* add updated example files

* fix CI errors

* change endpoints/connections list APIs to posts from gets

* connections lists from endpoints return resource IDs rather than full
objects.

* update examples files for endpoints connections list APIs

* fix operationIds and add descriptions

* fix more op ids and add descriptions for real

* fix typos, add constraints, and remove kbps/gbps from bandwidth (#4023)

* Updates to Resource Types (Modifications and Renames) (#4294)

* update orbital.json

* update examples

* prettier fix

* unfix old api version

* fix ci issues

* make more fields immutable

* update provisioning states

* swagger specs for Available groundstation APIs, version 2021-preview (#4920)

* swagger specs for Available groundstation APIs, version 2021-preview

* npm prettier check

* added type object

* removed capability and global comms info from responses

* prettier fix

* changed AP id response

* changes to schema to follow ARM format, resource id update

* Spelling check fix

* Ground Station spell check

* added groundstation to custom words

* Revert "added groundstation to custom words"

This reverts commit 0d7e18217de98836dcb8ba991685e15436004836.

* Revert "Ground Station spell check"

This reverts commit ef85b3b26f9ddf81dc1f50a9b677f9d8f115c4cf.

* Revert "Spelling check fix"

This reverts commit 6bd95c6e013889b6d488703846bbe87bbbb9c494.

* word addition

* type in response

* type definition in swagger

* readonly add

Co-authored-by: Akanksha Bhattacharyya <akankshab@microsoft.com>

* removed comms APIs

* readme updated

* fixed Swagger Avocado errors

* swagger lintDiff fix 1

* swagger lintDiff fix 2

* swagger lintDiff fix 3

Co-authored-by: Sunny Patel <sunny27710@gmail.com>
Co-authored-by: Sunny Patel <sunpatel@microsoft.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
Co-authored-by: Devanshu Singh <devasingh@microsoft.com>
Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>
Co-authored-by: Jim Harris <72156062+MicrosoftJim@users.noreply.github.com>
Co-authored-by: Akanksha Bhattacharyya <akanksha.nb@gmail.com>
Co-authored-by: Akanksha Bhattacharyya <akankshab@microsoft.com>

* operation IDs updated (#5461)

Co-authored-by: Devanshu Singh <devasingh@microsoft.com>

* Dev orbital microsoft.orbital 2021 04 04 preview (#5491)

* operation IDs updated

* updated OperationListResult definition

* review points implemented

Co-authored-by: Devanshu Singh <devasingh@microsoft.com>

* Azure Orbital - Review points implemented (#5507)

* operation IDs updated

* updated OperationListResult definition

* review points implemented

* referencing CloudError, ApiVersionParameter, ResourceGroupNameParameter, SubscriptionIdParameter from common-types

* reverting cloudError refs

* prettify json

* reorder some parameters

Co-authored-by: Devanshu Singh <devasingh@microsoft.com>
Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>

* Removed Empty allOf (#5510)

* operation IDs updated

* updated OperationListResult definition

* review points implemented

* referencing CloudError, ApiVersionParameter, ResourceGroupNameParameter, SubscriptionIdParameter from common-types

* reverting cloudError refs

* prettify json

* removed empty allOf

* validation checks

Co-authored-by: Devanshu Singh <devasingh@microsoft.com>

* readme.go.md fixed (#5512)

* operation IDs updated

* updated OperationListResult definition

* review points implemented

* referencing CloudError, ApiVersionParameter, ResourceGroupNameParameter, SubscriptionIdParameter from common-types

* reverting cloudError refs

* prettify json

* removed empty allOf

* validation checks

* readme.go.md fixed

Co-authored-by: Devanshu Singh <devasingh@microsoft.com>

* Remove last empty allOf (#5513)

* operation IDs updated

* updated OperationListResult definition

* review points implemented

* referencing CloudError, ApiVersionParameter, ResourceGroupNameParameter, SubscriptionIdParameter from common-types

* reverting cloudError refs

* prettify json

* removed empty allOf

* validation checks

* readme.go.md fixed

* remove one last empty allOf

Co-authored-by: Devanshu Singh <devasingh@microsoft.com>

* stable API version 2022-03-01

* valid json

* lint diff fix

* lint diff fix 2

* avocado fix

* lint diff warninga 1

* lint diff warnings 2

* prettier fix

* readme.me updated 2022-03-01

* Update readme.python.md

Co-authored-by: Sunny Patel <sunny27710@gmail.com>
Co-authored-by: Sunny Patel <sunpatel@microsoft.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
Co-authored-by: Devanshu Singh <devasingh@microsoft.com>
Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>
Co-authored-by: Jim Harris <72156062+MicrosoftJim@users.noreply.github.com>
Co-authored-by: Akanksha Bhattacharyya <akanksha.nb@gmail.com>
Co-authored-by: Akanksha Bhattacharyya <akankshab@microsoft.com>
Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[formrecognizer] generate on new swagger
3 participants