Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[formrecognizer] rename id documents -> identity documents #18474

Merged
merged 6 commits into from
May 3, 2021
Merged

[formrecognizer] rename id documents -> identity documents #18474

merged 6 commits into from
May 3, 2021

Conversation

kristapratico
Copy link
Member

@kristapratico kristapratico commented May 1, 2021 •
edited
Loading

Resolves #18449

@kristapratico kristapratico self-assigned this May 1, 2021
@kristapratico kristapratico marked this pull request as ready for review May 3, 2021 15:24
catalinaperalta
catalinaperalta approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A really small nit that could do in the future, I think since we changed everything to identity document, then we could also update the test file names to use the full identity word instead of just id. Also should we rename the directories holding the example identity documents? (the ones under samples/sample_forms/ and later on tests/sample_forms/)

@kristapratico
Copy link
Member Author

Looks great! A really small nit that could do in the future, I think since we changed everything to identity document, then we could also update the test file names to use the full identity word instead of just id. Also should we rename the directories holding the example identity documents? (the ones under samples/sample_forms/ and later on tests/sample_forms/)

Done!

@kristapratico kristapratico merged commit 8a82839 into Azure:master May 3, 2021
@kristapratico kristapratico deleted the rename-id-documents branch May 3, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinaperalta catalinaperalta catalinaperalta approved these changes

@iscai-msft iscai-msft Awaiting requested review from iscai-msft

Assignees

@kristapratico kristapratico

Labels
Cognitive - Form Recognizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[formrecognizer] rename recognize_id_documents -> recognize_identity_documents
2 participants
@kristapratico @catalinaperalta