Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[formrecognizer] update multipage receipt sample for tests #18473

Merged
merged 1 commit into from
May 3, 2021

Conversation

kristapratico
Copy link
Member

Resolves #18072

Preparation for targeting/testing the 2.1 GA endpoints - unskips some tests and updates the multipage receipt sample per service team recommendation.

Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just out of curiosity, why did the service team suggest the change?

@kristapratico
Copy link
Member Author

LGTM! Just out of curiosity, why did the service team suggest the change?

The original sample was created by our team but this was before we knew what a multipage sample for receipts should look like. The old sample reads more like an invoice, whereas the "correct" type of sample should be multiple sales receipt scanned/copied into a PDF. We've seen "regressions" on these tests for almost every new service version because it's not really the right sample for this prebuilt model. So fixing it finally. :)

@kristapratico kristapratico merged commit 8a5f878 into Azure:master May 3, 2021
@kristapratico kristapratico deleted the fix-form-tests branch May 3, 2021 15:44
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Apr 11, 2022
Dev-datamigration-Microsoft.DataMigration-2022-03-30-preview (Azure#18213)

* Initial Commit

* Updating the API version of files

* Adding New APIs, examples and properties

* fixing model validation and spell check error

* Adding Identifier to array

* Solving pretty check

* Adding TableList and Force delete

* Correcting table list example

* Updating expand description

* Updating examples

* Adding filestoragetype on swagger and minmi example

* Adding tablelist and sqldbthresholds to examples response

* Removing SQLDBbackupconfiguration and RowThreshold (Azure#18473)

* fixing s360 errors and adding secure strings (Azure#18593)

* fixing s360 errors and adding secure strings

* nit error

* pretty check

* fileshare password as secure string

* Revert "pretty check"

This reverts commit 677d27c00d5a1185a942873bc02fa54c08fcde03.

* nit error

* Revert "nit error"

This reverts commit 345b38af7f3344a85d666b547acd91fd769a66d2.

* removing extra space

* moving targetDatabaseCollation and provisioningError

Co-authored-by: Vasundhra Manhas <vmanhas@microsoft.com>

Co-authored-by: Vasundhra Manhas <42461257+vasundhraManhas@users.noreply.github.com>
Co-authored-by: Vasundhra Manhas <vmanhas@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[formrecognizer] update multipage receipt tests file
3 participants