[formrecognizer] adds samples for labeled tables and addresses sample/doc feedback #18409
Conversation
kristapratico
requested review from
benbp,
catalinaperalta and
iscai-msft
as code owners
...-ai-formrecognizer/samples/async_samples/sample_differentiate_output_labeled_tables_async.py
Outdated
Show resolved
Hide resolved
...ognizer/azure-ai-formrecognizer/samples/async_samples/sample_recognize_custom_forms_async.py
Outdated
Show resolved
Hide resolved
Yes, and they can download the files and put them in a container to train on. Let's them skip the whole labeling process and run the samples more easily. |
sdk/formrecognizer/azure-ai-formrecognizer/azure/ai/formrecognizer/_models.py
Show resolved
Hide resolved
...-ai-formrecognizer/samples/async_samples/sample_differentiate_output_labeled_tables_async.py
Show resolved
Hide resolved
| class TestDifferentiateOutputLabeledTablesAsync(object): | ||
|
|
||
| async def test_recognize_tables_fixed_rows_async(self): | ||
| from azure.core.credentials import AzureKeyCredential |
There was a problem hiding this comment.
hmm are the model ids created every time the sample is run? or how does the magic work?
Not blocking your PR, just curious
There was a problem hiding this comment.
No, these are static model IDs that get passed in as environment variables. All samples are run from an existing FR resource, nothing created on the fly here.
There was a problem hiding this comment.
I worry someone might delete the models and then all samples stop working, but it will be pretty clear, so easy to fix.
of course, if it ever becomes a problem the samples can be updated an in charge of creating the model too
There was a problem hiding this comment.
Yeah still looking for a better way to do this without having to add the "train a model" code to every custom form sample. Trying to keep the samples as focused as possible. I guess one option could be to make the samples have the option of training a model or passing an existing model_id and have the CI always do the former. Will look into this. #18465
...-ai-formrecognizer/samples/async_samples/sample_differentiate_output_labeled_tables_async.py
Show resolved
Hide resolved
...ognizer/azure-ai-formrecognizer/samples/async_samples/sample_recognize_custom_forms_async.py
Show resolved
Hide resolved
Resolves #18047
This also adds the training docs for the fixed/dynamic tables samples. We got feedback from the docs team that it was really helpful to have this for users.