[textanalytics] v3.1 preview.5 generation #18330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristapratico
commented
Apr 28, 2021
| @@ -305,6 +305,8 @@ def lro_get_next_page(lro_status_callback, first_page, continuation_token, show_ | |||
| parsed_url = urlparse(continuation_token) | |||
| job_id = parsed_url.path.split("/")[-1] | |||
| query_params = dict(parse_qsl(parsed_url.query.replace("$", ""))) | |||
| if "showStats" in query_params: | |||
| query_params.pop("showStats") | |||
There was a problem hiding this comment.
preview.4 didn't seem to send "showStats" in the nextLink. It does get sent in preview.5, so we need to pop the camel cased version or else it gets sent to requests and we get an "unexpected keyword argument 'showStats'" TypeError.
kristapratico
commented
Apr 28, 2021
| @@ -656,9 +656,6 @@ def analyze_sentiment( # type: ignore | |||
| :class:`~azure.ai.textanalytics.SentenceSentiment` objects | |||
| will have property `mined_opinions` containing the result of this analysis. Only available for | |||
| API version v3.1-preview and up. | |||
| :keyword str string_index_type: Specifies the method used to interpret string offsets. Possible values are | |||
| 'UnicodeCodePoint', 'TextElements_v8', or 'Utf16CodeUnit'. The default value is 'UnicodeCodePoint'. | |||
| Only available for API version v3.1-preview and up. | |||
There was a problem hiding this comment.
we have string_index_type duplicated in the docstring so I deleted one
kristapratico
commented
Apr 28, 2021
| @@ -26,7 +26,7 @@ | |||
| # pre-apply the client_cls positional argument so it needn't be explicitly passed below | |||
| TextAnalyticsClientPreparer = functools.partial(_TextAnalyticsClientPreparer, TextAnalyticsClient) | |||
|
|
|||
|
|
|||
| @pytest.mark.skip("404 Not Found") | |||
There was a problem hiding this comment.
healthcare endpoint doesn't seem deployed yet?
There was a problem hiding this comment.
yeah that seems to be the case, ok with skipping for now
kristapratico
commented
Apr 28, 2021
| @@ -185,6 +185,9 @@ def test_bad_credentials(self, client): | |||
| ], | |||
| polling_interval=self._interval(), | |||
| ) | |||
|
|
|||
| @pytest.mark.skip("Throws 400 on POST: (InvalidRequest) Job task parameter value bad is not supported for model-version " | |||
| "parameter for job task type NamedEntityRecognition. Supported values latest,2019-10-01,2020-07-01") | |||
There was a problem hiding this comment.
need to follow up on this behavior change
iscai-msft
approved these changes
Apr 28, 2021
| @@ -26,7 +26,7 @@ | |||
| # pre-apply the client_cls positional argument so it needn't be explicitly passed below | |||
| TextAnalyticsClientPreparer = functools.partial(_TextAnalyticsClientPreparer, TextAnalyticsClient) | |||
|
|
|||
|
|
|||
| @pytest.mark.skip("404 Not Found") | |||
There was a problem hiding this comment.
yeah that seems to be the case, ok with skipping for now
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Mar 23, 2022
Adding fixes for Jan 2022 preview version (sasUri/provisioningState params) & PoSH fixes (Azure#18330) * adding fixes for Jan 2022 preview version * adding fix for PoSH * removing un-needed params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.