-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[textanalytics] v3.1 preview.5 generation #18330
Conversation
@@ -305,6 +305,8 @@ def lro_get_next_page(lro_status_callback, first_page, continuation_token, show_ | |||
parsed_url = urlparse(continuation_token) | |||
job_id = parsed_url.path.split("/")[-1] | |||
query_params = dict(parse_qsl(parsed_url.query.replace("$", ""))) | |||
if "showStats" in query_params: | |||
query_params.pop("showStats") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preview.4 didn't seem to send "showStats" in the nextLink. It does get sent in preview.5, so we need to pop the camel cased version or else it gets sent to requests and we get an "unexpected keyword argument 'showStats'" TypeError.
@@ -656,9 +656,6 @@ def analyze_sentiment( # type: ignore | |||
:class:`~azure.ai.textanalytics.SentenceSentiment` objects | |||
will have property `mined_opinions` containing the result of this analysis. Only available for | |||
API version v3.1-preview and up. | |||
:keyword str string_index_type: Specifies the method used to interpret string offsets. Possible values are | |||
'UnicodeCodePoint', 'TextElements_v8', or 'Utf16CodeUnit'. The default value is 'UnicodeCodePoint'. | |||
Only available for API version v3.1-preview and up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have string_index_type
duplicated in the docstring so I deleted one
@@ -26,7 +26,7 @@ | |||
# pre-apply the client_cls positional argument so it needn't be explicitly passed below | |||
TextAnalyticsClientPreparer = functools.partial(_TextAnalyticsClientPreparer, TextAnalyticsClient) | |||
|
|||
|
|||
@pytest.mark.skip("404 Not Found") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
healthcare endpoint doesn't seem deployed yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that seems to be the case, ok with skipping for now
@@ -185,6 +185,9 @@ def test_bad_credentials(self, client): | |||
], | |||
polling_interval=self._interval(), | |||
) | |||
|
|||
@pytest.mark.skip("Throws 400 on POST: (InvalidRequest) Job task parameter value bad is not supported for model-version " | |||
"parameter for job task type NamedEntityRecognition. Supported values latest,2019-10-01,2020-07-01") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to follow up on this behavior change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow thank you so much krista you're a queen
@@ -26,7 +26,7 @@ | |||
# pre-apply the client_cls positional argument so it needn't be explicitly passed below | |||
TextAnalyticsClientPreparer = functools.partial(_TextAnalyticsClientPreparer, TextAnalyticsClient) | |||
|
|||
|
|||
@pytest.mark.skip("404 Not Found") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that seems to be the case, ok with skipping for now
Adding fixes for Jan 2022 preview version (sasUri/provisioningState params) & PoSH fixes (Azure#18330) * adding fixes for Jan 2022 preview version * adding fix for PoSH * removing un-needed params
No description provided.