Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceBus] add keyword override support to update_ methods in mgmt module #18210

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix mypy and pylint
  • Loading branch information
yunhaoling committed Apr 29, 2021
commit a55b94e2e084387b893ed60494b76c19e406aeef
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ async def create_queue(self, queue_name: str, **kwargs) -> QueueProperties:
forward_dead_lettered_messages_to=forward_dead_lettered_messages_to,
user_metadata=kwargs.pop("user_metadata", None),
)
to_create = queue._to_internal_entity()
to_create = queue._to_internal_entity(self.fully_qualified_namespace)
create_entity_body = CreateQueueBody(
content=CreateQueueBodyContent(
queue_description=to_create, # type: ignore
Expand Down Expand Up @@ -832,6 +832,7 @@ async def create_subscription(
:type auto_delete_on_idle: Union[~datetime.timedelta, str]
:rtype: ~azure.servicebus.management.SubscriptionProperties
"""
# pylint:disable=protected-access
_validate_entity_name_type(topic_name, display_name="topic_name")
forward_to = _normalize_entity_path_to_full_path_if_needed(
kwargs.pop("forward_to", None), self.fully_qualified_namespace
Expand Down Expand Up @@ -865,7 +866,7 @@ async def create_subscription(
auto_delete_on_idle=kwargs.pop("auto_delete_on_idle", None),
availability_status=None,
)
to_create = subscription._to_internal_entity() # type: ignore # pylint:disable=protected-access
to_create = subscription._to_internal_entity(self.fully_qualified_namespace) # type: ignore

create_entity_body = CreateSubscriptionBody(
content=CreateSubscriptionBodyContent(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -335,13 +335,13 @@ def _to_internal_entity(self, fully_qualified_namespace, kwargs=None):
else authorization_rules
)

self._internal_qd.auto_delete_on_idle = avoid_timedelta_overflow(
self._internal_qd.auto_delete_on_idle = avoid_timedelta_overflow( # type: ignore
kwargs.pop("auto_delete_on_idle", self.auto_delete_on_idle)
)
self._internal_qd.dead_lettering_on_message_expiration = (
kwargs.pop("dead_lettering_on_message_expiration", self.dead_lettering_on_message_expiration)
)
self._internal_qd.default_message_time_to_live = avoid_timedelta_overflow(
self._internal_qd.default_message_time_to_live = avoid_timedelta_overflow( # type: ignore
kwargs.pop("default_message_time_to_live", self.default_message_time_to_live)
)
self._internal_qd.duplicate_detection_history_time_window = (
Expand Down Expand Up @@ -607,7 +607,7 @@ def _to_internal_entity(self, kwargs=None):

if not self._internal_td:
self._internal_td = InternalTopicDescription()
self._internal_td.default_message_time_to_live = avoid_timedelta_overflow(
self._internal_td.default_message_time_to_live = avoid_timedelta_overflow( # type: ignore
kwargs.pop("default_message_time_to_live", self.default_message_time_to_live)
)
self._internal_td.max_size_in_megabytes = kwargs.pop("max_size_in_megabytes", self.max_size_in_megabytes)
Expand All @@ -630,7 +630,7 @@ def _to_internal_entity(self, kwargs=None):
)
self._internal_td.status = kwargs.pop("status", self.status)
self._internal_td.support_ordering = kwargs.pop("support_ordering", self.support_ordering)
self._internal_td.auto_delete_on_idle = avoid_timedelta_overflow(
self._internal_td.auto_delete_on_idle = avoid_timedelta_overflow( # type: ignore
kwargs.pop("auto_delete_on_idle", self.auto_delete_on_idle)
)
self._internal_td.enable_partitioning = kwargs.pop("enable_partitioning", self.enable_partitioning)
Expand Down Expand Up @@ -830,7 +830,7 @@ def _to_internal_entity(self, fully_qualified_namespace, kwargs=None):
self._internal_sd = InternalSubscriptionDescription()
self._internal_sd.lock_duration = kwargs.pop("lock_duration", self.lock_duration)
self._internal_sd.requires_session = kwargs.pop("requires_session", self.requires_session)
self._internal_sd.default_message_time_to_live = avoid_timedelta_overflow(
self._internal_sd.default_message_time_to_live = avoid_timedelta_overflow( # type: ignore
kwargs.pop("default_message_time_to_live", self.default_message_time_to_live)
)
self._internal_sd.dead_lettering_on_message_expiration = (
Expand Down Expand Up @@ -863,7 +863,7 @@ def _to_internal_entity(self, fully_qualified_namespace, kwargs=None):
)

self._internal_sd.user_metadata = kwargs.pop("user_metadata", self.user_metadata)
self._internal_sd.auto_delete_on_idle = avoid_timedelta_overflow(
self._internal_sd.auto_delete_on_idle = avoid_timedelta_overflow( # type: ignore
kwargs.pop("auto_delete_on_idle", self.auto_delete_on_idle)
)
self._internal_sd.entity_availability_status = kwargs.pop("availability_status", self.availability_status)
Expand Down