Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translation] run CI in PRs #17253

Merged
merged 4 commits into from
Mar 11, 2021
Merged

[translation] run CI in PRs #17253

merged 4 commits into from
Mar 11, 2021

Conversation

kristapratico
Copy link
Member

No description provided.

@@ -10,4 +10,4 @@ jobs:
AZURE_CLIENT_ID: $(aad-azure-sdk-test-client-id)
AZURE_CLIENT_SECRET: $(aad-azure-sdk-test-client-secret)
AZURE_TENANT_ID: $(aad-azure-sdk-test-tenant-id)
TEST_MODE: 'RunLiveNoRecord'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nitty nit: this will speed up your tests a little bit by not having recording infrastructure. Can add in later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding now, thanks!

@kristapratico kristapratico merged commit 6286f95 into Azure:master Mar 11, 2021
@kristapratico kristapratico deleted the fix-ci branch March 11, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants