Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Communication] Move core dependency to setup.py from dev_requirements in communication management package #16077

Merged
merged 3 commits into from
Jan 20, 2021
Merged

[Communication] Move core dependency to setup.py from dev_requirements in communication management package #16077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ce41ab
Move core dependency to setup.py from dev_requirements
Jan 11, 2021
e4e5f64
change azure core dependency version
Jan 11, 2021
ba03a5e
Update core version to be >=1.2.2
Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdk/communication/azure-communication-chat/dev_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
-e ../../../tools/azure-devtools
-e ../../../tools/azure-sdk-tools
-e ../../core/azure-core
../azure-communication-nspkg
-e ../azure-communication-administration
aiohttp>=3.0; python_version >= '3.5'
1 change: 1 addition & 0 deletions sdk/communication/azure-mgmt-communication/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
'msrest>=0.5.0',
'msrestazure>=0.4.32,<2.0.0',
'azure-common~=1.1',
"azure-core<2.0.0,>=1.2.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, change from " to ' in order to be consistent with line 84-86

],
extras_require={
":python_version<'3.0'": ['azure-mgmt-nspkg'],
Expand Down