[ServiceBus] Create rule by default create a TrueRuleFilter

sdk/servicebus/azure-servicebus/CHANGELOG.md

@@ -45,6 +45,7 @@ raise `ValueError` if the `queue_name` or `topic_name` does not match the `Entit
 
 **BugFixes**
 
+* `ServiceBusAdministrationClient.create_rule` by default now creates a `TrueRuleFilter` rule.
 * FQDNs and Connection strings are now supported even with strippable whitespace or protocol headers (e.g. 'sb://').
 * Using parameter `auto_lock_renewer` on a sessionful receiver alongside `ReceiveMode.ReceiveAndDelete` will no longer fail during receipt due to failure to register the message with the renewer.
 

sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_management_client_async.py

@@ -31,15 +31,14 @@
 from ...management import _constants as constants
 from ._shared_key_policy_async import AsyncServiceBusSharedKeyCredentialPolicy
 from ...management._models import QueueRuntimeProperties, QueueProperties, TopicProperties, TopicRuntimeProperties, \
-    SubscriptionProperties, SubscriptionRuntimeProperties, RuleProperties, NamespaceProperties
+    SubscriptionProperties, SubscriptionRuntimeProperties, RuleProperties, NamespaceProperties, TrueRuleFilter
 from ...management._xml_workaround_policy import ServiceBusXMLWorkaroundPolicy
 from ...management._handle_response_error import _handle_response_error
 from ...management._model_workaround import avoid_timedelta_overflow
 from ._utils import extract_data_template, extract_rule_data_template, get_next_template
 from ...management._utils import deserialize_rule_key_values, serialize_rule_key_values, \
     _validate_entity_name_type, _validate_topic_and_subscription_types, _validate_topic_subscription_and_rule_types
 
-
 if TYPE_CHECKING:
     from azure.core.credentials_async import AsyncTokenCredential  # pylint:disable=ungrouped-imports
 
@@ -801,7 +800,7 @@ async def create_rule(
          will own the to-be-created rule.
         :param rule_name: Name of the rule.
         :type rule_name: str
-        :keyword filter: The filter of the rule.
+        :keyword filter: The filter of the rule. The default value is ~azure.servicebus.management.TrueRuleFilter
         :type filter: Union[~azure.servicebus.management.CorrelationRuleFilter,
          ~azure.servicebus.management.SqlRuleFilter]
         :keyword action: The action of the rule.
@@ -813,7 +812,7 @@ async def create_rule(
 
         rule = RuleProperties(
             rule_name,
-            filter=kwargs.pop("filter", None),
+            filter=kwargs.pop("filter", TrueRuleFilter()),
             action=kwargs.pop("action", None),
             created_at_utc=None
         )

sdk/servicebus/azure-servicebus/azure/servicebus/management/_management_client.py

@@ -34,7 +34,7 @@
 from ._model_workaround import avoid_timedelta_overflow
 from . import _constants as constants
 from ._models import QueueRuntimeProperties, QueueProperties, TopicProperties, TopicRuntimeProperties, \
-    SubscriptionProperties, SubscriptionRuntimeProperties, RuleProperties, NamespaceProperties
+    SubscriptionProperties, SubscriptionRuntimeProperties, RuleProperties, NamespaceProperties, TrueRuleFilter
 from ._handle_response_error import _handle_response_error
 
 if TYPE_CHECKING:
@@ -805,7 +805,7 @@ def create_rule(self, topic_name, subscription_name, rule_name, **kwargs):
          will own the to-be-created rule.
         :param rule_name: Name of the rule.
         :type rule_name: str
-        :keyword filter: The filter of the rule.
+        :keyword filter: The filter of the rule. The default value is ~azure.servicebus.management.TrueRuleFilter
         :type filter: Union[~azure.servicebus.management.CorrelationRuleFilter,
          ~azure.servicebus.management.SqlRuleFilter]
         :keyword action: The action of the rule.
@@ -816,7 +816,7 @@ def create_rule(self, topic_name, subscription_name, rule_name, **kwargs):
 
         rule = RuleProperties(
             rule_name,
-            filter=kwargs.pop("filter", None),
+            filter=kwargs.pop("filter", TrueRuleFilter()),
             action=kwargs.pop("action", None),
             created_at_utc=None
         )

sdk/servicebus/azure-servicebus/tests/async_tests/mgmt_tests/test_mgmt_rules_async.py

@@ -36,6 +36,7 @@ async def test_async_mgmt_rule_create(self, servicebus_namespace_connection_stri
         rule_name_1 = 'test_rule_1'
         rule_name_2 = 'test_rule_2'
         rule_name_3 = 'test_rule_3'
+        rule_name_4 = 'test_rule_4'
 
         correlation_fitler = CorrelationRuleFilter(correlation_id='testcid', properties={
             "key_string": "str1",
@@ -83,10 +84,15 @@ async def test_async_mgmt_rule_create(self, servicebus_namespace_connection_stri
             rule_desc = await mgmt_service.get_rule(topic_name, subscription_name, rule_name_3)
             assert type(rule_desc.filter) == TrueRuleFilter
 
+            await mgmt_service.create_rule(topic_name, subscription_name, rule_name_4)
+            rule_desc = await mgmt_service.get_rule(topic_name, subscription_name, rule_name_4)
+            assert type(rule_desc.filter) == TrueRuleFilter
+
         finally:
             await mgmt_service.delete_rule(topic_name, subscription_name, rule_name_1)
             await mgmt_service.delete_rule(topic_name, subscription_name, rule_name_2)
             await mgmt_service.delete_rule(topic_name, subscription_name, rule_name_3)
+            await mgmt_service.delete_rule(topic_name, subscription_name, rule_name_4)
             await mgmt_service.delete_subscription(topic_name, subscription_name)
             await mgmt_service.delete_topic(topic_name)