[ServiceBus] Condition based error redesign + client validation alignment #15364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
yunhaoling
requested review from
KieranBrantnerMagee,
annatisch and
rakshith91
annatisch
reviewed
Nov 17, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/_base_handler.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/_common/message.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_sender.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/aio/_base_handler_async.py
Outdated
Show resolved
Hide resolved
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
reviewed
Nov 19, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/_common/receiver_mixins.py
Show resolved
Hide resolved
…nment' into yuling-sb-client-validation-alignment
KieranBrantnerMagee
previously approved these changes
Nov 19, 2020
There was a problem hiding this comment.
LGTM. This was not an easy set of changes, thank you @yunhaoling profusely for enduring all the flux that went into them.
(Noting for posterity: Intent to incrementally add some sort of SettleFailed/SendFailed "grouping" errors for ease-of-use, hopefully those helpers are not going to be gone for long, only nixed for now as we got the base scaffolding set to be backcompat-safe for GA.)
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
KieranBrantnerMagee
approved these changes
Nov 20, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Aug 11, 2021
LUIS Authoring V3.0 GA (Azure#15364) * v3.0 swagger * Unchange the preview folder * Changes in the readme * readme.go changes * Readme.md changes * Changes in th readme * Changing all v2 to v3 * Editing LUIS.authoring * Editing readme * Adding "fuzzyMatchingEnabled" property to some objects * solving syntax errors * Deleting SDK files * Solving errors * Editing package.json * Changes according to the comments * Changing the default value of some properties * Adding prettier check * Change * Revert "Change" This reverts commit ca991fbbc99602d75128a2f84b1510ae999f9948. * Add missing parts * Changes for the SDK Co-authored-by: MIDDLEEAST\v-mariamel <v-mariamel@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gist.github.com/yunhaoling/1c13d4e50f81be25d35962edb4430106#gistcomment-3525780