-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ServiceBus] Condition based error redesign + client validation alignment #15364
[ServiceBus] Condition based error redesign + client validation alignment #15364
Conversation
sdk/servicebus/azure-servicebus/azure/servicebus/_base_handler.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/_common/message.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_sender.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/aio/_base_handler_async.py
Outdated
Show resolved
Hide resolved
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/servicebus/azure-servicebus/azure/servicebus/_common/receiver_mixins.py
Show resolved
Hide resolved
…nment' into yuling-sb-client-validation-alignment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This was not an easy set of changes, thank you @yunhaoling profusely for enduring all the flux that went into them.
(Noting for posterity: Intent to incrementally add some sort of SettleFailed/SendFailed "grouping" errors for ease-of-use, hopefully those helpers are not going to be gone for long, only nixed for now as we got the base scaffolding set to be backcompat-safe for GA.)
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
LUIS Authoring V3.0 GA (Azure#15364) * v3.0 swagger * Unchange the preview folder * Changes in the readme * readme.go changes * Readme.md changes * Changes in th readme * Changing all v2 to v3 * Editing LUIS.authoring * Editing readme * Adding "fuzzyMatchingEnabled" property to some objects * solving syntax errors * Deleting SDK files * Solving errors * Editing package.json * Changes according to the comments * Changing the default value of some properties * Adding prettier check * Change * Revert "Change" This reverts commit ca991fbbc99602d75128a2f84b1510ae999f9948. * Add missing parts * Changes for the SDK Co-authored-by: MIDDLEEAST\v-mariamel <v-mariamel@microsoft.com>
https://gist.github.com/yunhaoling/1c13d4e50f81be25d35962edb4430106#gistcomment-3525780