[Communication] Phone Number Management - Nov Release #15182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* commit last version of long run operation * begin_create_search -> begin_reserve_phone_numbers begin_purchase_search -> begin_purchase_reservation * Add ReleasePhoneNumberPolling * fix input params of release phone numbers * update async methods * update samples * update tests * fix the client for params when purchasing numbers * update samples * update live tests * update comment of keyword body * search_id -> reservation_id * update tests for search_id -> reservation_id * update samples for serach_id -> reservation_id * put client as a positional argument to override from_continuation_token method * Ignore W0221: parameters differ from overridden lint error * update swagger for changing search id -> reservation id and Search -> Reservation * refresh auto generated code * update client method to return PhoneNumberReservation instead of PhoneNumberSearch * add document types for __init__ function of polling * rename body to options when starts a reservation * update tests for the param changes * update samples due to arg name change in begin_reserve_phone_numbers * fix some missing name changes
… Nov release (#15041) * add changelog for Nov release * add a section to beaking changes log * add a section to new features log * add backquote and period to the changelog
HeliWang
changed the title
HeliWang
changed the title
HeliWang
requested review from
RezaJooyandeh,
ankitarorabit,
turalf and
xiangyan99
HeliWang
changed the title
xiangyan99
reviewed
Nov 10, 2020
sdk/communication/azure-communication-administration/CHANGELOG.md
Outdated
Show resolved
Hide resolved
xiangyan99
approved these changes
Nov 10, 2020
ankitarorabit
approved these changes
Nov 10, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Jul 22, 2021
[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01-preview (Azure#15182) * initial actual changes * added example * corrected mistake in previous contract * fix prettier changes * fix model validation errors * fix readonly * fix prettier issue Co-authored-by: Swagat Mishra <swagatm@microsoft.com>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Jul 22, 2021
[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01-preview (Azure#15182) * initial actual changes * added example * corrected mistake in previous contract * fix prettier changes * fix model validation errors * fix readonly * fix prettier issue Co-authored-by: Swagat Mishra <swagatm@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the feature branch into master for Nov release.