Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] Non-reusable Sender/Receiver #15172

Merged
merged 2 commits into from
Nov 10, 2020
Merged

[ServiceBus] Non-reusable Sender/Receiver #15172

merged 2 commits into from
Nov 10, 2020

Conversation

yunhaoling
Copy link
Contributor

Addressing issue: #15085

Align Non-reusable Sender/Receiver with other languages.

@ghost ghost added the Service Bus label Nov 9, 2020
@yunhaoling yunhaoling linked an issue Nov 9, 2020 that may be closed by this pull request
[ServiceBus] Making Sender/Receiver non-usable #15085
Closed
@yunhaoling
Copy link
Contributor Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

KieranBrantnerMagee
KieranBrantnerMagee approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@KieranBrantnerMagee KieranBrantnerMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very Solid choices on ValueError (I had to check that myself) and the Event() usage++

@yunhaoling yunhaoling merged commit e3ce017 into Azure:master Nov 10, 2020
@yunhaoling yunhaoling deleted the yuling-sb-non-reusable-handler branch November 10, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KieranBrantnerMagee KieranBrantnerMagee KieranBrantnerMagee approved these changes

@annatisch annatisch Awaiting requested review from annatisch

@rakshith91 rakshith91 Awaiting requested review from rakshith91

Assignees
No one assigned
Labels
Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ServiceBus] Making Sender/Receiver non-usable
2 participants
@yunhaoling @KieranBrantnerMagee