Ma remove readonly assignments #14478

xiangyan99 · 2020-10-13T23:34:31Z

No description provided.

kristapratico · 2020-10-13T23:37:08Z

sdk/metricsadvisor/azure-ai-metricsadvisor/azure/ai/metricsadvisor/models/_models.py

@@ -2356,19 +2356,19 @@ def __init__(
        super(Incident, self).__init__(**kwargs)
        self.metric_id = kwargs.get('metric_id', None)
        self.detection_configuration_id = kwargs.get('detection_configuration_id', None)
-        self.incident_id = kwargs.get('incident_id', None)
+        self.id = kwargs.get('id', None)


should we include this rename in the Changelog?

No. This is a bug rather than a renaming. We used id in docstring. :(

ghost · 2020-10-13T23:38:59Z

Hello @xiangyan99!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

* [metricsadvisor] live tests setup (#14396) * add live test yml for metrics advisor * some fixes * hardcode test ids and rerecord a few tests * add ids back as env variables * [formrecognizer] initial business cards (#14026) * Sync eng/common directory with azure-sdk-tools for PR 1081 (#14445) Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1081 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow) * Communication Administration: Add on-demand resource creation for live-tests (#14366) * Add communication service preparer * Refactor dynamic resource creation testing code * Remove setup method of base test class * Change fake conn str to valid format * Remove unused import * Remove main test file * Reduce RG expiry durtion * Async test code change with resource preparer * Add chaching for resource-preparer * Move helper into shared * Move preparer into shared * Uncomment test code * Remove CommunicationResourceGroupPreparer use common instead * Add base testcase for sync pnm * move phone_number_helper to phone_number folder * Add base pnm async testcase * Add __init__ for test folders * Fix identity tests to refer to shared test folder * Refactor base async phonenumber test class * Make decorator consisitent across all async tests utm * Replace fake resource value * Fix type in test file names * Remove commented cache setting code * Add livetest recording files * Refresh recording files * Update recording files * Reorganize the test folder structure * Add mgmt pacakge to the dev reqs Co-authored-by: tural farhadov <tufarhad@microsoft.com> * [ServiceBus] Small stress test and sample touchups (#14304) * Emplace sample generated for customer issue on the side for future reference. (generate sas token and authenticate) * Adjust stress test that was using push receive instead of pull. * Add async version of non-session to session send failure test, make both cached to improve perf. * Codegen for Azure Monitor (#14057) * Codegen fro Azure Monitor * codeowner * commit 2 * Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md * doc setings * Update eng/.docsettings.yml * Update eng/.docsettings.yml * Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md * Update eng/.docsettings.yml * version * oops * comments * Update sdk/monitor/opentelemetry-exporter-azuremonitor/LICENSE.txt Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com> Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com> * [Storage][FileShare]Regenerate for delete leased snapshot (#14469) * add repr to models (#14475) * remove validations (#14476) * Ma remove readonly assignments (#14478) * Ensure azure-identity readme has exactly one H1 (#14480) The docs publishing system disallows multiple H1 headings in a document. * Sync eng/common directory with azure-sdk-tools for PR 1088 (#14482) * Add pipeline configuration for cleaning up upstream branches * Fix powershell naming * Switch to use github API * Use github API to delete branches Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> * enable live tests (#14467) * Removed asynctestcase.py (#14444) * testcase.py now uses AzureTestCase (#14443) Co-authored-by: Krista Pratico <krpratic@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: turalf <tural.ferhadov@gmail.com> Co-authored-by: tural farhadov <tufarhad@microsoft.com> Co-authored-by: KieranBrantnerMagee <kibrantn@microsoft.com> Co-authored-by: Rakshith Bhyravabhotla <sabhyrav@microsoft.com> Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com> Co-authored-by: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com> Co-authored-by: Charles Lowell <chlowe@microsoft.com> Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: Bradley D'Amato <53579156+bradleydamato@users.noreply.github.com>

* customize httpadapter to honor kwargs in send method * update * update * update * update * update * update * update * FI from master (#14501) * [metricsadvisor] live tests setup (#14396) * add live test yml for metrics advisor * some fixes * hardcode test ids and rerecord a few tests * add ids back as env variables * [formrecognizer] initial business cards (#14026) * Sync eng/common directory with azure-sdk-tools for PR 1081 (#14445) Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1081 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow) * Communication Administration: Add on-demand resource creation for live-tests (#14366) * Add communication service preparer * Refactor dynamic resource creation testing code * Remove setup method of base test class * Change fake conn str to valid format * Remove unused import * Remove main test file * Reduce RG expiry durtion * Async test code change with resource preparer * Add chaching for resource-preparer * Move helper into shared * Move preparer into shared * Uncomment test code * Remove CommunicationResourceGroupPreparer use common instead * Add base testcase for sync pnm * move phone_number_helper to phone_number folder * Add base pnm async testcase * Add __init__ for test folders * Fix identity tests to refer to shared test folder * Refactor base async phonenumber test class * Make decorator consisitent across all async tests utm * Replace fake resource value * Fix type in test file names * Remove commented cache setting code * Add livetest recording files * Refresh recording files * Update recording files * Reorganize the test folder structure * Add mgmt pacakge to the dev reqs Co-authored-by: tural farhadov <tufarhad@microsoft.com> * [ServiceBus] Small stress test and sample touchups (#14304) * Emplace sample generated for customer issue on the side for future reference. (generate sas token and authenticate) * Adjust stress test that was using push receive instead of pull. * Add async version of non-session to session send failure test, make both cached to improve perf. * Codegen for Azure Monitor (#14057) * Codegen fro Azure Monitor * codeowner * commit 2 * Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md * doc setings * Update eng/.docsettings.yml * Update eng/.docsettings.yml * Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md * Update eng/.docsettings.yml * version * oops * comments * Update sdk/monitor/opentelemetry-exporter-azuremonitor/LICENSE.txt Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com> Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com> * [Storage][FileShare]Regenerate for delete leased snapshot (#14469) * add repr to models (#14475) * remove validations (#14476) * Ma remove readonly assignments (#14478) * Ensure azure-identity readme has exactly one H1 (#14480) The docs publishing system disallows multiple H1 headings in a document. * Sync eng/common directory with azure-sdk-tools for PR 1088 (#14482) * Add pipeline configuration for cleaning up upstream branches * Fix powershell naming * Switch to use github API * Use github API to delete branches Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> * enable live tests (#14467) * Removed asynctestcase.py (#14444) * testcase.py now uses AzureTestCase (#14443) Co-authored-by: Krista Pratico <krpratic@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: turalf <tural.ferhadov@gmail.com> Co-authored-by: tural farhadov <tufarhad@microsoft.com> Co-authored-by: KieranBrantnerMagee <kibrantn@microsoft.com> Co-authored-by: Rakshith Bhyravabhotla <sabhyrav@microsoft.com> Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com> Co-authored-by: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com> Co-authored-by: Charles Lowell <chlowe@microsoft.com> Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: Bradley D'Amato <53579156+bradleydamato@users.noreply.github.com> * update * update * update * update * update * update * update * update Co-authored-by: Krista Pratico <krpratic@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: turalf <tural.ferhadov@gmail.com> Co-authored-by: tural farhadov <tufarhad@microsoft.com> Co-authored-by: KieranBrantnerMagee <kibrantn@microsoft.com> Co-authored-by: Rakshith Bhyravabhotla <sabhyrav@microsoft.com> Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com> Co-authored-by: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com> Co-authored-by: Charles Lowell <chlowe@microsoft.com> Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: Bradley D'Amato <53579156+bradleydamato@users.noreply.github.com>

xiangyan99 added 2 commits October 13, 2020 16:25

remove readonly assignments

d0f6235

update

15ba521

xiangyan99 requested a review from kristapratico October 13, 2020 23:34

kristapratico reviewed Oct 13, 2020

View reviewed changes

kristapratico approved these changes Oct 13, 2020

View reviewed changes

xiangyan99 added the auto-merge label Oct 13, 2020

ghost merged commit 91ca08f into master Oct 13, 2020

ghost deleted the ma_remove_readonly_assignments branch October 13, 2020 23:51

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ma remove readonly assignments #14478

Ma remove readonly assignments #14478

xiangyan99 commented Oct 13, 2020

kristapratico Oct 13, 2020

xiangyan99 Oct 13, 2020

ghost commented Oct 13, 2020

Ma remove readonly assignments #14478

Ma remove readonly assignments #14478

Conversation

xiangyan99 commented Oct 13, 2020

kristapratico Oct 13, 2020

Choose a reason for hiding this comment

xiangyan99 Oct 13, 2020

Choose a reason for hiding this comment

ghost commented Oct 13, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.