-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ServiceBus] settlement and mgmt error redesign #14178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhaoling
added
Service Bus
Client
This issue points to a problem in the data-plane of the library.
labels
Oct 1, 2020
yunhaoling
changed the title
[ServiceBus] settlement and mgmt error redesign init commit
[ServiceBus] settlement and mgmt error redesign
Oct 1, 2020
yunhaoling
requested review from
annatisch and
KieranBrantnerMagee
as code owners
October 9, 2020 17:11
/check-enforcer reset |
/check-enforcer evaluate |
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/servicebus/azure-servicebus/azure/servicebus/_base_handler.py
Outdated
Show resolved
Hide resolved
…essage error, update readme and changelog
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Looks like all the comments in the PR have been addressed |
sdk/servicebus/azure-servicebus/azure/servicebus/_common/message.py
Outdated
Show resolved
Hide resolved
Co-authored-by: KieranBrantnerMagee <kibrantn@microsoft.com>
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/check-enforcer reset |
KieranBrantnerMagee
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_sevicebus_exception
from a big chuck into small pieces targeting different kind of amqp errorsServiceBusError
MessageSettleFailed