Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] settlement and mgmt error redesign #14178

Merged
merged 13 commits into from
Oct 23, 2020
Merged

[ServiceBus] settlement and mgmt error redesign #14178

merged 13 commits into from
Oct 23, 2020

Conversation

yunhaoling
Copy link
Contributor

@yunhaoling yunhaoling commented Oct 1, 2020 •
edited
Loading

  • error handling refactor
    • split create_sevicebus_exception from a big chuck into small pieces targeting different kind of amqp errors
  • amqp mgmt request would now raise concrete error instead of the too-general ServiceBusError
  • settlement method would now raise concrete error instead of the too-general MessageSettleFailed

@yunhaoling yunhaoling added Service Bus Client This issue points to a problem in the data-plane of the library. labels Oct 1, 2020
@yunhaoling yunhaoling changed the title [ServiceBus] settlement and mgmt error redesign init commit [ServiceBus] settlement and mgmt error redesign Oct 1, 2020
@KieranBrantnerMagee KieranBrantnerMagee mentioned this pull request Oct 1, 2020
Closed
@KieranBrantnerMagee KieranBrantnerMagee linked an issue Oct 1, 2020 that may be closed by this pull request
[Service Bus] Change management request and settlement error handling to raise specific errors #11255
Closed
@yunhaoling yunhaoling marked this pull request as ready for review October 9, 2020 17:11
@yunhaoling
Copy link
Contributor Author

/check-enforcer reset

@yunhaoling
Copy link
Contributor Author

/check-enforcer evaluate

@yunhaoling
Copy link
Contributor Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling
Copy link
Contributor Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling
Copy link
Contributor Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a
Copy link
Contributor

Looks like all the comments in the PR have been addressed
@KieranBrantnerMagee, @annatisch Can we have the final approval so that we can get this PR merged?

@yunhaoling
Copy link
Contributor Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling
Copy link
Contributor Author

/check-enforcer reset

@yunhaoling yunhaoling merged commit bb28c10 into Azure:master Oct 23, 2020
@yunhaoling yunhaoling deleted the yuling-sb-error-improve branch November 24, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KieranBrantnerMagee KieranBrantnerMagee KieranBrantnerMagee approved these changes

@annatisch annatisch Awaiting requested review from annatisch

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Service Bus] Change management request and settlement error handling to raise specific errors
3 participants
@yunhaoling @ramya-rao-a @KieranBrantnerMagee