Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADL] BREAKING CHANGE: Adl object refactor #1303

Closed
wants to merge 1 commit into from

Conversation

AutorestCI
Copy link
Contributor

Generated from RestAPI PR: Azure/azure-rest-api-specs#1429

@codecov-io
Copy link

codecov-io commented Jul 18, 2017

Codecov Report

Merging #1303 into master will increase coverage by 0.01%.
The diff coverage is 74.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
+ Coverage   55.83%   55.85%   +0.01%     
==========================================
  Files        2626     2629       +3     
  Lines       70080    70120      +40     
==========================================
+ Hits        39132    39166      +34     
- Misses      30948    30954       +6
Impacted Files Coverage Δ
.../mgmt/datalake/store/models/firewall_rule_paged.py 80% <ø> (ø) ⬆️
...nalytics/account/models/storage_container_paged.py 80% <ø> (ø) ⬆️
...count/models/data_lake_store_account_info_paged.py 80% <ø> (ø) ⬆️
...e/analytics/account/models/sas_token_info_paged.py 80% <ø> (ø) ⬆️
...ytics/account/models/storage_account_info_paged.py 80% <ø> (ø) ⬆️
...e/analytics/account/models/compute_policy_paged.py 100% <ø> (ø) ⬆️
...ke/analytics/account/models/firewall_rule_paged.py 80% <ø> (ø) ⬆️
...datalake/store/models/trusted_id_provider_paged.py 80% <ø> (ø) ⬆️
...lake/analytics/account/models/storage_container.py 55.55% <0%> (ø) ⬆️
...mgmt/datalake/analytics/account/models/__init__.py 100% <100%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d775677...d500596. Read the comment docs.

@lmazuel lmazuel requested a review from begoldsm July 18, 2017 15:20
@lmazuel lmazuel changed the title Automatic PR from RestAPI-PR1429 [ADL] BREAKING CHANGE: Adl object refactor Jul 18, 2017
@begoldsm
Copy link
Contributor

@lmazuel I am constantly amazed by Python. This is technically a "breaking" change because we are changing object types for different return values, but because the tests already didn't try to validate fields that didn't exist and python doesn't really care about types, all my tests continue to pass!

@begoldsm
Copy link
Contributor

@lmazuel I assume that I need to update the versions for the ADL packages manually before committing this, right?

@lmazuel
Copy link
Member

lmazuel commented Jul 18, 2017

@begoldsm yes please! version and Changelog :)

@begoldsm
Copy link
Contributor

I am closing this PR as I am working with @ro-joowan to manually generate an aggregated ADL python SDK update.

@begoldsm begoldsm closed this Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants