Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token refresh offset #12136

Merged
merged 33 commits into from
Jul 17, 2020
Merged

token refresh offset #12136

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
dc1a9b2
token refresh offset
xiangyan99 Jun 19, 2020
bd7ae61
update
xiangyan99 Jun 19, 2020
6a58f5c
update
xiangyan99 Jun 19, 2020
2a94b3d
rename is_refresh to should_refresh
xiangyan99 Jun 22, 2020
51fbed8
update
xiangyan99 Jun 24, 2020
9ed71f1
update
xiangyan99 Jun 24, 2020
618c226
Merge branch 'master' into identity_token_refresh_offset
xiangyan99 Jun 24, 2020
e6ab928
updates
xiangyan99 Jun 24, 2020
e235ad2
updates
xiangyan99 Jun 24, 2020
6d51768
updates
xiangyan99 Jun 24, 2020
beb9027
updates
xiangyan99 Jun 25, 2020
08fa31e
expose token_refresh_offset
xiangyan99 Jun 26, 2020
2bec84f
update
xiangyan99 Jun 26, 2020
66fe30b
pylint fix
xiangyan99 Jun 27, 2020
b2b4b43
updates
xiangyan99 Jun 29, 2020
4eb71a0
pylint fix
xiangyan99 Jun 29, 2020
e060268
update
xiangyan99 Jun 29, 2020
0d9e63e
use option bags
xiangyan99 Jun 30, 2020
9ba3910
pylint fix
xiangyan99 Jun 30, 2020
10499c4
updates
xiangyan99 Jun 30, 2020
d93fdba
updates
xiangyan99 Jul 14, 2020
78518cd
updates
xiangyan99 Jul 14, 2020
82ad53a
updates
xiangyan99 Jul 14, 2020
429ca27
update
xiangyan99 Jul 14, 2020
99e8921
updates
xiangyan99 Jul 14, 2020
a57f7fa
updates
xiangyan99 Jul 14, 2020
e08692f
updates
xiangyan99 Jul 15, 2020
101fa22
updates
xiangyan99 Jul 15, 2020
a38294a
updates
xiangyan99 Jul 15, 2020
173e26d
update
xiangyan99 Jul 15, 2020
533ab8c
update
xiangyan99 Jul 17, 2020
b6e1cc7
update
xiangyan99 Jul 17, 2020
04dad9d
updates
xiangyan99 Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@xiangyan99
xiangyan99 committed Jul 17, 2020
commit 533ab8c8fe171ff0721613712300f8302c64c2f3
21 changes: 0 additions & 21 deletions sdk/identity/azure-identity/tests/test_aad_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,24 +223,3 @@ def test_should_refresh():
client._last_refresh_time = now - DEFAULT_TOKEN_REFRESH_RETRY_DELAY + 1
should_refresh = client.should_refresh(token)
assert not should_refresh


def test_token_refresh_kwargs():
client = AadClient("test", "test")
now = int(time.time())

# do not need refresh
token = AccessToken("token", now + DEFAULT_REFRESH_OFFSET + 1)
should_refresh = client.should_refresh(token)
assert not should_refresh

# need refresh
token = AccessToken("token", now + DEFAULT_REFRESH_OFFSET - 1)
should_refresh = client.should_refresh(token)
assert should_refresh

# not exceed cool down time, do not refresh
token = AccessToken("token", now + DEFAULT_REFRESH_OFFSET - 1)
client._last_refresh_time = now - DEFAULT_TOKEN_REFRESH_RETRY_DELAY + 1
should_refresh = client.should_refresh(token)
assert not should_refresh
21 changes: 0 additions & 21 deletions sdk/identity/azure-identity/tests/test_aad_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,24 +230,3 @@ async def test_should_refresh():
client._last_refresh_time = now - DEFAULT_TOKEN_REFRESH_RETRY_DELAY + 1
should_refresh = client.should_refresh(token)
assert not should_refresh


async def test_token_refresh_kwargs():
client = AadClient("test", "test")
now = int(time.time())

# do not need refresh
token = AccessToken("token", now + DEFAULT_REFRESH_OFFSET + 1)
should_refresh = client.should_refresh(token)
assert not should_refresh

# need refresh
token = AccessToken("token", now + DEFAULT_REFRESH_OFFSET - 1)
should_refresh = client.should_refresh(token)
assert should_refresh

# not exceed cool down time, do not refresh
token = AccessToken("token", now + DEFAULT_REFRESH_OFFSET - 1)
client._last_refresh_time = now - DEFAULT_TOKEN_REFRESH_RETRY_DELAY + 1
should_refresh = client.should_refresh(token)
assert not should_refresh
21 changes: 0 additions & 21 deletions sdk/identity/azure-identity/tests/test_authn_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,24 +254,3 @@ def test_should_refresh():
client._last_refresh_time = now - DEFAULT_TOKEN_REFRESH_RETRY_DELAY + 1
should_refresh = client.should_refresh(token)
assert not should_refresh


def test_token_refresh_kwargs():
client = AuthnClient(endpoint="http://foo")
now = int(time.time())

# do not need refresh
token = AccessToken("token", now + DEFAULT_REFRESH_OFFSET + 1)
should_refresh = client.should_refresh(token)
assert not should_refresh

# need refresh
token = AccessToken("token", now + DEFAULT_REFRESH_OFFSET - 1)
should_refresh = client.should_refresh(token)
assert should_refresh

# not exceed cool down time, do not refresh
token = AccessToken("token", now + DEFAULT_REFRESH_OFFSET - 1)
client._last_refresh_time = now - DEFAULT_TOKEN_REFRESH_RETRY_DELAY + 1
should_refresh = client.should_refresh(token)
assert not should_refresh
21 changes: 0 additions & 21 deletions sdk/identity/azure-identity/tests/test_authn_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,24 +58,3 @@ async def test_should_refresh():
client._last_refresh_time = now - DEFAULT_TOKEN_REFRESH_RETRY_DELAY + 1
should_refresh = client.should_refresh(token)
assert not should_refresh


async def test_token_refresh_kwargs():
client = AsyncAuthnClient(endpoint="http://foo")
now = int(time.time())

# do not need refresh
token = AccessToken("token", now + DEFAULT_REFRESH_OFFSET + 1)
should_refresh = client.should_refresh(token)
assert not should_refresh

# need refresh
token = AccessToken("token", now + DEFAULT_REFRESH_OFFSET - 1)
should_refresh = client.should_refresh(token)
assert should_refresh

# not exceed cool down time, do not refresh
token = AccessToken("token", now + DEFAULT_REFRESH_OFFSET - 1)
client._last_refresh_time = now - DEFAULT_TOKEN_REFRESH_RETRY_DELAY + 1
should_refresh = client.should_refresh(token)
assert not should_refresh