release for mgmt vmware #12003
Merged
release for mgmt vmware #12003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changlong-liu
approved these changes
Jun 16, 2020
|
Still need to wait for service team to confirm about the client name. Please don't merge. |
ctaggart
suggested changes
Jun 17, 2020
| from setuptools import find_packages, setup | ||
|
|
||
| # Change the PACKAGE_NAME only to change folder and different name | ||
| PACKAGE_NAME = "azure-mgmt-vmware" |
|
|
||
| # Change the PACKAGE_NAME only to change folder and different name | ||
| PACKAGE_NAME = "azure-mgmt-vmware" | ||
| PACKAGE_PPRINT_NAME = "Vmware Management" |
There was a problem hiding this comment.
Where does this show up? May be AVS Management or Azure VMware Solution Management. See how it is referred to in the REST API docs https://docs.microsoft.com/en-us/rest/api/avs/
|
@Abyssknight Please also change the swagger readme.python.md |
ctaggart
suggested changes
Jun 18, 2020
| from . import models | ||
|
|
||
|
|
||
| class AVSClient(SDKClient): |
| @@ -0,0 +1,5 @@ | |||
| [packaging] | |||
| package_name = "azure-mgmt-avs" | |||
| @@ -0,0 +1,5 @@ | |||
| [packaging] | |||
| package_name = "azure-mgmt-avs" | |||
| package_pprint_name = "VMWare Solution Management" | |||
There was a problem hiding this comment.
I'm not sure where this shows up, but AVS is Azure VMware Solution. Definitely VMWare needs to be changed to VMware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/439