Make live managed identity tests independent of soft delete #10879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
added
Client
xiangyan99
reviewed
Apr 16, 2020
sdk/identity/azure-identity/tests/managed-identity-live/test_managed_identity_live.py
Show resolved
Hide resolved
xiangyan99
previously approved these changes
Apr 17, 2020
xiangyan99
approved these changes
Apr 17, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Apr 20, 2020
…into fr_samples * 'master' of https://github.com/Azure/azure-sdk-for-python: release mgmt loganalytics 0.4.0 (Azure#10923) Refresh appservice test (Azure#10911) Alertsmanagement test (Azure#10912) regeneated cosmos (Azure#10907) adding azure core to packaging (Azure#10910) [formrecognizer] update docstrings and adds literalincludes (Azure#10901) [formrecognizer] enable mypy (Azure#10864) Make live managed identity tests independent of soft delete (Azure#10879) [pylint] check newlines on docstring admonition statements for ms docs (Azure#10844) Add Search Synonym Maps (Azure#10831) Adding Ashish to CODEOWNERS for storage folder (Azure#10870) [text analytics] fix readme (Azure#10881) Track2 flakey test improvements (Azure#10767) [formrecognizer] error map (Azure#10882) [Batch] Update Management API used (Azure#10797) Autogenerated tests for keyvault (Azure#10849) Regenerated attestation (Azure#10847) [DataLake][FixDoc]The Doc is not accurate for rename operation (Azure#10857) [formrecognizer] working on tests (Azure#10711) [formrecognizer] preview 1 design changes (Azure#10677)
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Apr 20, 2020
…into fr_readme * 'master' of https://github.com/Azure/azure-sdk-for-python: [formrecognizer] rename async training method to train_model and sync method to begin_train_model (Azure#10929) Adding Azure Core Requirements (Azure#10926) release mgmt loganalytics 0.4.0 (Azure#10923) Refresh appservice test (Azure#10911) Alertsmanagement test (Azure#10912) regeneated cosmos (Azure#10907) adding azure core to packaging (Azure#10910) [formrecognizer] update docstrings and adds literalincludes (Azure#10901) [formrecognizer] enable mypy (Azure#10864) Make live managed identity tests independent of soft delete (Azure#10879) [pylint] check newlines on docstring admonition statements for ms docs (Azure#10844)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When soft delete is enabled for the Key Vault used by these tests, the second case executed will fail because it tries to set and delete a secret deleted by the first case executed. When these tests were written soft delete was disabled by default on new Key Vaults. Now it's enabled by default.
It doesn't matter which Key Vault operation the tests attempt because the purpose is to validate the access token acquired by the credential. The simple fix here is to list the vault's secrets. This eliminates problems due to the state of the Vault's secrets (and requires authorization even when the vault has none).