Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added user agent suffix #10328

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def __init__(
policies = [
HeadersPolicy(**kwargs),
ProxyPolicy(proxies=proxies),
UserAgentPolicy(base_user_agent=_utils.get_user_agent(), **kwargs),
UserAgentPolicy(base_user_agent=_utils.get_user_agent(self.connection_policy), **kwargs),
ContentDecodePolicy(),
retry_policy,
CustomHookPolicy(**kwargs),
Expand Down
9 changes: 6 additions & 3 deletions sdk/cosmos/azure-cosmos/azure/cosmos/_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,15 @@
import platform
import re
from ._version import VERSION
from .documents import ConnectionPolicy


def get_user_agent():
def get_user_agent(
connection_policy # type: ConnectionPolicy
):
os_name = safe_user_agent_header(platform.platform())
python_version = safe_user_agent_header(platform.python_version())
user_agent = "azsdk-python-cosmos/{} Python/{} ({})".format(VERSION, python_version, os_name)
user_agent_suffix = connection_policy.UserAgentSuffix[0:128]
user_agent = "azsdk-python-cosmos/{} Python/{} ({}) {}".format(VERSION, python_version, os_name, user_agent_suffix)
return user_agent


Expand Down
6 changes: 5 additions & 1 deletion sdk/cosmos/azure-cosmos/azure/cosmos/documents.py
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,10 @@ class ConnectionPolicy(object): # pylint: disable=too-many-instance-attributes
:ivar ConnectionRetryConfiguration:
Retry Configuration to be used for connection retries.
:vartype ConnectionRetryConfiguration:
int or azure.cosmos.ConnectionRetryPolicy or urllib3.util.retry
int or azure.cosmos.ConnectionRetryPolicy or urllib3.util.
:ivar string UserAgentSuffix:
The value to be appended to the user-agent header, used for monitoring purposes.

"""

__defaultRequestTimeout = 60000 # milliseconds
Expand All @@ -371,6 +374,7 @@ def __init__(self):
self.DisableSSLVerification = False
self.UseMultipleWriteLocations = False
self.ConnectionRetryConfiguration = None
self.UserAgentSuffix = ""


class _OperationType(object):
Expand Down
20 changes: 18 additions & 2 deletions sdk/cosmos/azure-cosmos/test/utils_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import pytest
import azure.cosmos
import azure.cosmos._utils as _utils
from azure.cosmos.documents import ConnectionPolicy
import platform
import test_config

Expand All @@ -34,15 +35,30 @@ class UtilsTests(unittest.TestCase):
"""

def test_user_agent(self):
user_agent = _utils.get_user_agent()
connection_policy = ConnectionPolicy()
user_agent = _utils.get_user_agent(connection_policy)

expected_user_agent = "azsdk-python-cosmos/{} Python/{} ({})".format(
expected_user_agent = "azsdk-python-cosmos/{} Python/{} ({}) ".format(
azure.cosmos.__version__,
platform.python_version(),
platform.platform()
)
self.assertEqual(user_agent, expected_user_agent)

def test_user_agent_with_suffix(self):
user_agent_suffix = "sample app"
connection_policy = ConnectionPolicy()
connection_policy.UserAgentSuffix = user_agent_suffix
user_agent = _utils.get_user_agent(connection_policy)

expected_user_agent = "azsdk-python-cosmos/{} Python/{} ({}) {}".format(
azure.cosmos.__version__,
platform.python_version(),
platform.platform(),
user_agent_suffix
)
self.assertEqual(user_agent, expected_user_agent)

def test_connection_string(self):
client = azure.cosmos.CosmosClient.from_connection_string(test_config._test_config.connection_str)
databases = list(client.list_databases())
Expand Down