Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-customproviders-for-mgmt-0.1.0 #10160

Merged
merged 4 commits into from
Mar 10, 2020

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented Mar 8, 2020

No description provided.

@adxsdk6
Copy link

adxsdk6 commented Mar 8, 2020

Can one of the admins verify this patch?

from .version import VERSION


class customprovidersClientConfiguration(AzureConfiguration):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder why it's lowercase

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine for now

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should fix it, otherwise we will introduce breaking change in the future

@qiaozha
Copy link
Member Author

qiaozha commented Mar 10, 2020

@zikalino Can you approve this now?

@@ -0,0 +1,5 @@
# Release History

## 0.1.0rc1 (2020-03-08)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for rc1 here?

@qiaozha qiaozha merged commit 1a3a438 into master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants