Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Batch API support #1001

Merged
merged 17 commits into from
Feb 23, 2017
Merged

New Batch API support #1001

merged 17 commits into from
Feb 23, 2017

Conversation

annatisch
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 17, 2017

Codecov Report

Merging #1001 into master will increase coverage by 0.15%.
The diff coverage is 82.3%.

@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
+ Coverage   57.69%   57.85%   +0.15%     
==========================================
  Files        1927     1931       +4     
  Lines       53341    53398      +57     
==========================================
+ Hits        30773    30891     +118     
+ Misses      22568    22507      -61
Impacted Files Coverage Δ
azure-batch/azure/batch/models/job_statistics.py 100% <ø> (ø)
...zure-batch/azure/batch/models/task_list_options.py 27.27% <ø> (ø)
...h/models/compute_node_enable_scheduling_options.py 42.85% <ø> (ø)
azure-batch/azure/batch/models/exit_conditions.py 100% <ø> (ø)
...dels/job_preparation_task_execution_information.py 35.71% <ø> (ø)
azure-batch/azure/batch/models/pool_information.py 100% <ø> (ø)
...atch/models/file_list_from_compute_node_options.py 33.33% <ø> (ø)
...e-batch/azure/batch/models/pool_patch_parameter.py 100% <ø> (ø)
...atch/azure/batch/models/auto_pool_specification.py 55.55% <ø> (ø)
azure-batch/azure/batch/models/task_constraints.py 100% <ø> (ø)
... and 206 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77dd758...3c8fd54. Read the comment docs.

@annatisch
Copy link
Member Author

@lmazuel - This is ready to merge if you think everything looks properly set up for release :)

++++++++++++++++++

- AAD token authentication now supported.
- Support for running tasks under a predefined or automatic user account.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention the changed method names like pool_list_pool_usage_metrics -> pool_list_usage_metrics, or is that too detailed for this history file?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, do we want to clarify that the run as user changes apply to all "task-y" things (task, job manager task, start task, job prep, job release), but the scoped auth only applies to task and job manager task?

3.0.0 (2017-02-17)
++++++++++++++++++

- Updated `BatchAccount` model - support for pool allocation in the users subscription.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

users -> user's here since it's possessive?

++++++++++++++++++

- Updated `BatchAccount` model - support for pool allocation in the users subscription.
- Updated `BatchAccount` model - support for referencing an Azure Key Vault when allocation pools in users subscription.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"allocating pools in the user's subscription" ?
"for accounts created with a pool allocation mode of UserSubscription" is another way I've seen in the Swagger spec.

@annatisch annatisch merged commit a1bbd28 into Azure:master Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants