-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Batch API support #1001
New Batch API support #1001
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
+ Coverage 57.69% 57.85% +0.15%
==========================================
Files 1927 1931 +4
Lines 53341 53398 +57
==========================================
+ Hits 30773 30891 +118
+ Misses 22568 22507 -61
Continue to review full report at Codecov.
|
@lmazuel - This is ready to merge if you think everything looks properly set up for release :) |
azure-batch/HISTORY.rst
Outdated
++++++++++++++++++ | ||
|
||
- AAD token authentication now supported. | ||
- Support for running tasks under a predefined or automatic user account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention the changed method names like pool_list_pool_usage_metrics -> pool_list_usage_metrics, or is that too detailed for this history file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, do we want to clarify that the run as user changes apply to all "task-y" things (task, job manager task, start task, job prep, job release), but the scoped auth only applies to task and job manager task?
azure-mgmt-batch/HISTORY.rst
Outdated
3.0.0 (2017-02-17) | ||
++++++++++++++++++ | ||
|
||
- Updated `BatchAccount` model - support for pool allocation in the users subscription. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
users -> user's here since it's possessive?
azure-mgmt-batch/HISTORY.rst
Outdated
++++++++++++++++++ | ||
|
||
- Updated `BatchAccount` model - support for pool allocation in the users subscription. | ||
- Updated `BatchAccount` model - support for referencing an Azure Key Vault when allocation pools in users subscription. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"allocating pools in the user's subscription" ?
"for accounts created with a pool allocation mode of UserSubscription" is another way I've seen in the Swagger spec.
No description provided.