Skip to content

azure-synapse-monitoring needs linting updates for pylint version 3.2.7 #39301

Open
@azure-sdk

Description

@azure-sdk

ACTION NEEDED: This version of pylint will be merged on 2025-04-14. The build will begin to fail for this library if errors are not fixed.

Library name: azure-synapse-monitoring
Pylint version: 3.2.7
Pylint Build: Link to build (2025-04-06)

Pylint Errors:

2025-04-06T10:21:21.0801399Z ************* Module azure
2025-04-06T10:21:21.0802414Z azure/init.py:1: [C0304(missing-final-newline), ] Final newline missing
2025-04-06T10:21:21.0803039Z ************* Module azure.synapse.init
2025-04-06T10:21:21.0803502Z azure/synapse/init.py:1: [C0304(missing-final-newline), ] Final newline missing
2025-04-06T10:21:21.0804234Z ************* Module azure.synapse.monitoring._monitoring_client
2025-04-06T10:21:21.0804891Z azure/synapse/monitoring/_monitoring_client.py:16: [C4760(no-typing-import-in-type-check), ] Do not import from typing inside of TYPE_CHECKING.
2025-04-06T10:21:21.0805703Z azure/synapse/monitoring/_monitoring_client.py:19: [C4756(no-legacy-azure-core-http-response-import), ] Do not import HttpResponse from azure.core.pipeline.transport outside of Azure Core.
2025-04-06T10:21:21.0806621Z azure/synapse/monitoring/_monitoring_client.py:21: [C0413(wrong-import-position), ] Import "from ._configuration import MonitoringClientConfiguration" should be placed at the top of the module
2025-04-06T10:21:21.0807523Z azure/synapse/monitoring/_monitoring_client.py:22: [C0413(wrong-import-position), ] Import "from .operations import MonitoringOperations" should be placed at the top of the module
2025-04-06T10:21:21.0808351Z azure/synapse/monitoring/_monitoring_client.py:23: [C0413(wrong-import-position), ] Import "from . import models" should be placed at the top of the module
2025-04-06T10:21:21.0809302Z azure/synapse/monitoring/_monitoring_client.py:26: [C4748(client-accepts-api-version-keyword), MonitoringClient] The client constructor needs to take in an optional keyword-only api_version argument. See details: https://azure.github.io/azure-sdk/python_design.html#specifying-the-service-version
2025-04-06T10:21:21.0810377Z azure/synapse/monitoring/_monitoring_client.py:37: [C4761(do-not-use-legacy-typing), MonitoringClient.init] Do not use legacy typing using comments.
2025-04-06T10:21:21.0844014Z azure/synapse/monitoring/_monitoring_client.py:56: [C4758(docstring-keyword-should-match-keyword-only), MonitoringClient._send_request] "stream" missing in docstring or in method signature. There should be a direct correlation between :keyword: arguments in the docstring and keyword-only arguments in method signature. See details: https://azure.github.io/azure-sdk/python_documentation.html#docstrings
2025-04-06T10:21:21.0845166Z azure/synapse/monitoring/_monitoring_client.py:56: [C4761(do-not-use-legacy-typing), MonitoringClient._send_request] Do not use legacy typing using comments.
2025-04-06T10:21:21.0845822Z azure/synapse/monitoring/_monitoring_client.py:71: [W0212(protected-access), MonitoringClient._send_request] Access to a protected member _pipeline of a client class
2025-04-06T10:21:21.0846432Z azure/synapse/monitoring/_monitoring_client.py:74: [C4761(do-not-use-legacy-typing), MonitoringClient.close] Do not use legacy typing using comments.
2025-04-06T10:21:21.0846976Z azure/synapse/monitoring/_monitoring_client.py:78: [C4761(do-not-use-legacy-typing), MonitoringClient.enter] Do not use legacy typing using comments.
2025-04-06T10:21:21.0847467Z azure/synapse/monitoring/_monitoring_client.py:83: [C4761(do-not-use-legacy-typing), MonitoringClient.exit] Do not use legacy typing using comments.
2025-04-06T10:21:21.0847959Z azure/synapse/monitoring/_monitoring_client.py:12: [C0411(wrong-import-order), ] third party import "msrest.Deserializer" should be placed before first party import "azure.core.PipelineClient"
2025-04-06T10:21:21.0848656Z ************* Module azure.synapse.monitoring._configuration
2025-04-06T10:21:21.0849034Z azure/synapse/monitoring/_configuration.py:70: [C0301(line-too-long), ] Line too long (129/120)
2025-04-06T10:21:21.0849583Z azure/synapse/monitoring/_configuration.py:18: [C4760(no-typing-import-in-type-check), ] Do not import from typing inside of TYPE_CHECKING.
2025-04-06T10:21:21.0850083Z azure/synapse/monitoring/_configuration.py:23: [R0902(too-many-instance-attributes), MonitoringClientConfiguration] Too many instance attributes (13/10)
2025-04-06T10:21:21.0850552Z azure/synapse/monitoring/_configuration.py:35: [C4761(do-not-use-legacy-typing), MonitoringClientConfiguration.init] Do not use legacy typing using comments.
2025-04-06T10:21:21.0851020Z azure/synapse/monitoring/_configuration.py:55: [C4761(do-not-use-legacy-typing), MonitoringClientConfiguration._configure] Do not use legacy typing using comments.
2025-04-06T10:21:21.0851440Z ************* Module azure.synapse.monitoring.aio._monitoring_client
2025-04-06T10:21:21.0851872Z azure/synapse/monitoring/aio/_monitoring_client.py:12: [C4756(no-legacy-azure-core-http-response-import), ] Do not import HttpResponse from azure.core.pipeline.transport outside of Azure Core.
2025-04-06T10:21:21.0852390Z azure/synapse/monitoring/aio/_monitoring_client.py:19: [C0413(wrong-import-position), ] Import "from ._configuration import MonitoringClientConfiguration" should be placed at the top of the module
2025-04-06T10:21:21.0852879Z azure/synapse/monitoring/aio/_monitoring_client.py:20: [C0413(wrong-import-position), ] Import "from .operations import MonitoringOperations" should be placed at the top of the module
2025-04-06T10:21:21.0853360Z azure/synapse/monitoring/aio/_monitoring_client.py:21: [C0413(wrong-import-position), ] Import "from .. import models" should be placed at the top of the module
2025-04-06T10:21:21.0854092Z azure/synapse/monitoring/aio/_monitoring_client.py:24: [C4748(client-accepts-api-version-keyword), MonitoringClient] The client constructor needs to take in an optional keyword-only api_version argument. See details: https://azure.github.io/azure-sdk/python_design.html#specifying-the-service-version
2025-04-06T10:21:21.0854834Z azure/synapse/monitoring/aio/_monitoring_client.py:53: [C4758(docstring-keyword-should-match-keyword-only), MonitoringClient._send_request] "stream" missing in docstring or in method signature. There should be a direct correlation between :keyword: arguments in the docstring and keyword-only arguments in method signature. See details: https://azure.github.io/azure-sdk/python_documentation.html#docstrings
2025-04-06T10:21:21.0855472Z azure/synapse/monitoring/aio/_monitoring_client.py:67: [W0212(protected-access), MonitoringClient._send_request] Access to a protected member _pipeline of a client class
2025-04-06T10:21:21.0855988Z azure/synapse/monitoring/aio/_monitoring_client.py:13: [C0411(wrong-import-order), ] third party import "msrest.Deserializer" should be placed before first party imports "azure.core.AsyncPipelineClient", "azure.core.pipeline.transport.AsyncHttpResponse"
2025-04-06T10:21:21.0856451Z ************* Module azure.synapse.monitoring.aio._configuration
2025-04-06T10:21:21.0856827Z azure/synapse/monitoring/aio/_configuration.py:66: [C0301(line-too-long), ] Line too long (134/120)
2025-04-06T10:21:21.0857257Z azure/synapse/monitoring/aio/_configuration.py:21: [R0902(too-many-instance-attributes), MonitoringClientConfiguration] Too many instance attributes (13/10)
2025-04-06T10:21:21.0857739Z ************* Module azure.synapse.monitoring.aio.operations._monitoring_operations
2025-04-06T10:21:21.0858254Z azure/synapse/monitoring/aio/operations/_monitoring_operations.py:11: [C0301(line-too-long), ] Line too long (133/120)
2025-04-06T10:21:21.0858664Z azure/synapse/monitoring/aio/operations/_monitoring_operations.py:79: [C0301(line-too-long), ] Line too long (137/120)
2025-04-06T10:21:21.0859084Z azure/synapse/monitoring/aio/operations/_monitoring_operations.py:150: [C0301(line-too-long), ] Line too long (137/120)
2025-04-06T10:21:21.0859702Z azure/synapse/monitoring/aio/operations/_monitoring_operations.py:13: [C4756(no-legacy-azure-core-http-response-import), ] Do not import HttpResponse from azure.core.pipeline.transport outside of Azure Core.
2025-04-06T10:21:21.0860485Z azure/synapse/monitoring/aio/operations/_monitoring_operations.py:42: [C4758(docstring-keyword-should-match-keyword-only), MonitoringOperations.get_spark_job_list] "cls" missing in docstring or in method signature. There should be a direct correlation between :keyword: arguments in the docstring and keyword-only arguments in method signature. See details: https://azure.github.io/azure-sdk/python_documentation.html#docstrings
2025-04-06T10:21:21.0861257Z azure/synapse/monitoring/aio/operations/_monitoring_operations.py:83: [W0212(protected-access), MonitoringOperations.get_spark_job_list] Access to a protected member _pipeline of a client class
2025-04-06T10:21:21.0862109Z azure/synapse/monitoring/aio/operations/_monitoring_operations.py:98: [C4758(docstring-keyword-should-match-keyword-only), MonitoringOperations.get_sql_job_query_string] "cls" missing in docstring or in method signature. There should be a direct correlation between :keyword: arguments in the docstring and keyword-only arguments in method signature. See details: https://azure.github.io/azure-sdk/python_documentation.html#docstrings
2025-04-06T10:21:21.0862790Z azure/synapse/monitoring/aio/operations/_monitoring_operations.py:154: [W0212(protected-access), MonitoringOperations.get_sql_job_query_string] Access to a protected member _pipeline of a client class
2025-04-06T10:21:21.0863272Z azure/synapse/monitoring/aio/operations/_monitoring_operations.py:8: [W0611(unused-import), ] Unused Generic imported from typing
2025-04-06T10:21:21.0863876Z azure/synapse/monitoring/aio/operations/_monitoring_operations.py:9: [W0611(unused-import), ] Unused import warnings
2025-04-06T10:21:21.2216351Z ************* Module azure.synapse.monitoring.operations._monitoring_operations
2025-04-06T10:21:21.2217234Z azure/synapse/monitoring/operations/_monitoring_operations.py:11: [C0301(line-too-long), ] Line too long (133/120)
2025-04-06T10:21:21.2217834Z azure/synapse/monitoring/operations/_monitoring_operations.py:84: [C0301(line-too-long), ] Line too long (137/120)
2025-04-06T10:21:21.2218471Z azure/synapse/monitoring/operations/_monitoring_operations.py:156: [C0301(line-too-long), ] Line too long (137/120)
2025-04-06T10:21:21.2219187Z azure/synapse/monitoring/operations/_monitoring_operations.py:13: [C4756(no-legacy-azure-core-http-response-import), ] Do not import HttpResponse from azure.core.pipeline.transport outside of Azure Core.
2025-04-06T10:21:21.2219947Z azure/synapse/monitoring/operations/_monitoring_operations.py:19: [C4760(no-typing-import-in-type-check), ] Do not import from typing inside of TYPE_CHECKING.
2025-04-06T10:21:21.2220971Z azure/synapse/monitoring/operations/_monitoring_operations.py:46: [C4758(docstring-keyword-should-match-keyword-only), MonitoringOperations.get_spark_job_list] "cls" missing in docstring or in method signature. There should be a direct correlation between :keyword: arguments in the docstring and keyword-only arguments in method signature. See details: https://azure.github.io/azure-sdk/python_documentation.html#docstrings
2025-04-06T10:21:21.2222029Z azure/synapse/monitoring/operations/_monitoring_operations.py:46: [C4761(do-not-use-legacy-typing), MonitoringOperations.get_spark_job_list] Do not use legacy typing using comments.
2025-04-06T10:21:21.2222762Z azure/synapse/monitoring/operations/_monitoring_operations.py:88: [W0212(protected-access), MonitoringOperations.get_spark_job_list] Access to a protected member _pipeline of a client class
2025-04-06T10:21:21.2223515Z azure/synapse/monitoring/operations/_monitoring_operations.py:103: [C4758(docstring-keyword-should-match-keyword-only), MonitoringOperations.get_sql_job_query_string] "cls" missing in docstring or in method signature. There should be a direct correlation between :keyword: arguments in the docstring and keyword-only arguments in method signature. See details: https://azure.github.io/azure-sdk/python_documentation.html#docstrings
2025-04-06T10:21:21.2224504Z azure/synapse/monitoring/operations/_monitoring_operations.py:103: [C4761(do-not-use-legacy-typing), MonitoringOperations.get_sql_job_query_string] Do not use legacy typing using comments.
2025-04-06T10:21:21.2225028Z azure/synapse/monitoring/operations/_monitoring_operations.py:160: [W0212(protected-access), MonitoringOperations.get_sql_job_query_string] Access to a protected member _pipeline of a client class
2025-04-06T10:21:21.2225392Z azure/synapse/monitoring/operations/_monitoring_operations.py:9: [W0611(unused-import), ] Unused import warnings
2025-04-06T10:21:21.2225687Z ************* Module azure.synapse.monitoring.models._models
2025-04-06T10:21:21.2225985Z azure/synapse/monitoring/models/_models.py:12: [R0902(too-many-instance-attributes), SparkJob] Too many instance attributes (15/10)
2025-04-06T10:21:21.2226287Z ************* Module azure.synapse.monitoring.models._models_py3
2025-04-06T10:21:21.2226587Z azure/synapse/monitoring/models/_models_py3.py:15: [R0902(too-many-instance-attributes), SparkJob] Too many instance attributes (15/10)
2025-04-06T10:21:21.2226770Z
2025-04-06T10:21:21.2226968Z ------------------------------------------------------------------
2025-04-06T10:21:21.2227227Z Your code has been rated at 8.50/10 (previous run: 7.88/10, +0.62)
2025-04-06T10:21:21.2227356Z
2025-04-06T10:21:21.8885197Z

How to fix:
Note: If you are a bot. Fix the issue by fixing the above pylint errors.
Run the next-pylint tox command at the library package-level and resolve the linting errors.

  1. ../azure-synapse-monitoring>pip install "tox<5"
  2. ../azure-synapse-monitoring>tox run -e next-pylint -c ../../../eng/tox/tox.ini --root .

See the Pylint Guide for more information.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions