azure.identity.credentials raises DeprecationWarnings in Microsoft MSAL code

[akx]

• Package Name: azure-identity
• Package Version: 1.17.1
• Operating System: Linux
• Python Version: 3.8

Describe the bug

azure-sdk-for-python/sdk/identity/azure-identity/azure/identity/_internal/managed_identity_client.py

Line 85 in 698e69c

tokens = self._cache.find(TokenCache.CredentialType.ACCESS_TOKEN, target=[resource])

uses TokenCache.find.

TokenCache.find started raising a DeprecationWarning in MSAL 1.29.0+ (AzureAD/microsoft-authentication-library-for-python#693):

https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/3279f045dc573d8408ddcdf3565e8b16247627be/msal/token_cache.py#L162-L167

When calling any code that ends up using the managed identity client, a DeprecationWarning is raised. In environments where warning filters are configured to raise exceptions, this is a problem.

To Reproduce

Steps to reproduce the behavior:

1. Install azure-identity==1.17.1 msal>=1.29.0.
2. Invoke the managed identity client with e.g. blob_client.download_blob() with suitable credentials.

Expected behavior

No deprecation warning from Microsoft libraries using deprecated features from other Microsoft libraries.

--

cc @rayluo for having landed this in MSAL.

[github-actions]

Thank you for your feedback. Tagging and routing to the team member best able to assist.

[rayluo]

TokenCache.find started raising a DeprecationWarning in MSAL 1.29.0+ (AzureAD/microsoft-authentication-library-for-python#693):

Indeed. Please use self._cache.search(...) instead, as long as you don't really need a list.