Open
Description
openedon Aug 8, 2023
This method:
Claims that None
for a response is ok, but the code is actually far from being able to deal with that, and the risk that it raises an AttributeError
is really high. All usage in azure-core today pass a response
object, which makes the issue not obvious unless typing gets involved.
After discussing with @annatisch , I open an issue to consider refactoring this code to be more explicit about None
behavior. In the meantime, for typing purposes we will cast the response in the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment