Skip to content

[pylint] don't log errors that we end up raising  #22557

Open

Description

We don't want to log errors that we end up raising. For example, in this code we both log the error at a warning level, and throw it as well.

One idea is to look at .warning, .info, .error function calls and if they're in an exception block where we end up raising the exception, throw a pylint error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

ClientThis issue points to a problem in the data-plane of the library.EngSysThis issue is impacting the engineering system.good first issueThis issue tracks work that may be a good starting point for a first-time contributorhelp wantedThis issue is tracking work for which community contributions would be welcomed and appreciatedpylint

Type

No type

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions