Skip to content

[SB] Update API type hints for methods that accept dicts #17000

Closed

Description

Complete after : #14807

In the above PR, changes were made to SB so that dict representations of the following objects are
now accepted and can be sent:

  • ServiceBusMessage
  • QueueProperties
  • TopicProperties
  • SubscriptionProperties
  • RuleProperties

The API type hints that now accept dict representations of these objects should be updated to reflect the change. The type hint should show that an object of type typing.Mapping is accepted, NOT AN OBJECT OF TYPE Dict. Discussion for this update here: https://github.com/Azure/azure-sdk-for-python/pull/14807/files#r579153824.

The type hints for the following methods should be updated:

  • _from_list in message.py
  • add_message in message.py
  • schedule_messages in _servicebus_sender.py
  • send_messages in _servicebus_sender.py
  • schedule_messages in _servicebus_sender_async.py
  • send_messages in _servicebus_sender_async.py
  • update_queue, update_topic, update_subscription, update_rule in management/_management_client.py
    • update_queue, update_topic, update_subscription, update_rule in aio/management/_management_client_async.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions