Parameterize Dockerfiles (#24637)

* ensure that we parameterize all docker files in the repo with targeted docker repo as a build argument

.vscode/cspell.json

@@ -157,6 +157,7 @@
     "deserialization",
     "docfx",
     "dotenv",
+    "dpkg",
     "DWORD",
     "eastus",
     "eckey",
@@ -499,7 +500,8 @@
         "nlocals",
         "kwonlyargcount",
         "dcid",
-        "startf"
+        "startf",
+        "dpkg"
       ]
     }
   ],

sdk/eventhub/azure-eventhub/stress/Dockerfile

@@ -1,6 +1,7 @@
-# syntax=docker/dockerfile:1
-
-FROM python:3.8-slim-buster
+# internal users should provide MCR registry to build via 'docker build . --build-arg REGISTRY="mcr.microsoft.com/mirror/docker/library/"'
+# public OSS users should simply leave this argument blank or ignore its presence entirely
+ARG REGISTRY=""
+FROM ${REGISTRY}python:3.8-slim-buster
 
 WORKDIR /app
 

sdk/identity/azure-identity/tests/azure-functions/Dockerfile

@@ -3,7 +3,13 @@
 # Licensed under the MIT License.
 # ------------------------------------
 # docker can't tell when the repo has changed and will therefore cache this layer
-FROM alpine/git as repo
+
+# internal users should provide MCR registry to build via 'docker build . --build-arg REGISTRY="mcr.microsoft.com/mirror/docker/library/"'
+# public OSS users should simply leave this argument blank or ignore its presence entirely
+ARG REGISTRY=""
+
+FROM ${REGISTRY}alpine:3.14 as repo
+RUN apk --no-cache add git
 RUN git clone https://github.com/Azure/azure-sdk-for-python --single-branch --depth 1 /azure-sdk-for-python
 
 

sdk/identity/azure-identity/tests/managed-identity-live/Dockerfile

@@ -2,14 +2,18 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
 # ------------------------------------
+
+# internal users should provide MCR registry to build via 'docker build . --build-arg REGISTRY="mcr.microsoft.com/mirror/docker/library/"'
+# public OSS users should simply leave this argument blank or ignore its presence entirely
+ARG REGISTRY=""
 ARG PYTHON_VERSION=3.9
 
 # docker can't tell when the repo has changed and will therefore cache this layer
-FROM alpine/git as repo
+FROM ${REGISTRY}alpine:3.14 as repo
+RUN apk --no-cache add git
 RUN git clone https://github.com/Azure/azure-sdk-for-python --single-branch --depth 1 /azure-sdk-for-python
 
-
-FROM python:${PYTHON_VERSION}-slim
+FROM ${REGISTRY}python:${PYTHON_VERSION}-slim
 
 COPY --from=repo /azure-sdk-for-python/sdk/identity /sdk/identity
 COPY --from=repo /azure-sdk-for-python/sdk/core/azure-core /sdk/core/azure-core

sdk/servicebus/azure-servicebus/stress/Dockerfile

@@ -1,6 +1,7 @@
-# syntax=docker/dockerfile:1
-
-FROM python:3.8-slim-buster
+# internal users should provide MCR registry to build via 'docker build . --build-arg REGISTRY="mcr.microsoft.com/mirror/docker/library/"'
+# public OSS users should simply leave this argument blank or ignore its presence entirely
+ARG REGISTRY=""
+FROM ${REGISTRY}python:3.8-slim-buster
 
 WORKDIR /app
 

tools/Dockerfile

@@ -1,5 +1,9 @@
-FROM ubuntu
-MAINTAINER zikalino
+# internal users should provide MCR registry to build via 'docker build . --build-arg REGISTRY="mcr.microsoft.com/mirror/docker/library/"'
+# public OSS users should simply leave this argument blank or ignore its presence entirely
+ARG REGISTRY=""
+FROM ${REGISTRY}ubuntu:20.04
+LABEL MAINTAINER=zikalino \
+      MAINTAINER=scbedd
 
 RUN apt-get update
 RUN apt-get install -y git curl gnupg vim python3 python3-pip git software-properties-common apt-transport-https wget python3-venv nodejs npm libunwind-dev