Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Fix doctype that had old name, make changelog note more precise.

Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
  • Loading branch information
KieranBrantnerMagee and yunhaoling authored Oct 2, 2020
1 parent 584d7e5 commit 27fbac5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sdk/servicebus/azure-servicebus/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

**Breaking Changes**
* Passing any type other than `ReceiveMode` as parameter `receive_mode` now throws a `TypeError` instead of `AttributeError`.
* Administration Client calls now take only entity names, not `EntityDescriptions` as well to reduce ambiguity in which entity was being acted on. TypeError will now be thrown on improper parameter types (non-string.)
* Administration Client calls now take only entity names, not `<Entity>Descriptions` as well to reduce ambiguity in which entity was being acted on. TypeError will now be thrown on improper parameter types (non-string).

## 7.0.0b6 (2020-09-10)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -882,7 +882,7 @@ async def delete_rule(
:param str topic_name: The topic that owns the subscription.
:param str subscription_name: The subscription that
owns the topic.
:param str rule: The to-be-deleted rule.
:param str rule_name: The to-be-deleted rule.
:rtype: None
"""
_validate_topic_subscription_and_rule_types(topic_name, subscription_name, rule_name)
Expand Down

0 comments on commit 27fbac5

Please sign in to comment.