update

sdk/metricsadvisor/azure-ai-metricsadvisor/azure/ai/metricsadvisor/_helpers.py

@@ -190,9 +190,7 @@ def convert_to_sub_feedback(feedback):
     raise HttpResponseError("Invalid feedback type returned in the response.")
 
 def convert_datetime(date_time):
-    # type: (Union[str, datetime.datetime]) -> Optional[datetime.datetime]
-    if not date_time:
-        return None
+    # type: (Union[str, datetime.datetime]) -> datetime.datetime
     if isinstance(date_time, datetime.datetime):
         return date_time
     if isinstance(date_time, str):

sdk/metricsadvisor/azure-ai-metricsadvisor/azure/ai/metricsadvisor/_metrics_advisor_client.py

@@ -7,7 +7,6 @@
 # pylint: disable=protected-access
 
 from typing import List, Union, Dict, Any, cast, TYPE_CHECKING
-import datetime  # pylint:disable=unused-import
 
 from azure.core.tracing.decorator import distributed_trace
 from ._metrics_advisor_key_credential import MetricsAdvisorKeyCredential
@@ -38,6 +37,7 @@
 from ._version import SDK_MONIKER
 
 if TYPE_CHECKING:
+    import datetime
     from ._generated.models import (
         SeriesResult,
         EnrichmentStatus,
@@ -203,8 +203,8 @@ def list_feedbacks(self, metric_id, **kwargs):
         feedback_type = kwargs.pop('feedback_type', None)
         start_time = kwargs.pop('start_time', None)
         end_time = kwargs.pop('end_time', None)
-        converted_start_time = convert_datetime(start_time)
-        converted_end_time = convert_datetime(end_time)
+        converted_start_time = convert_datetime(start_time) if start_time else None
+        converted_end_time = convert_datetime(end_time) if end_time else None
         time_mode = kwargs.pop('time_mode', None)
         feedback_filter = MetricFeedbackFilter(
             metric_id=metric_id,

sdk/metricsadvisor/azure-ai-metricsadvisor/azure/ai/metricsadvisor/aio/_metrics_advisor_client_async.py

@@ -207,8 +207,8 @@ def list_feedbacks(
         feedback_type = kwargs.pop('feedback_type', None)
         start_time = kwargs.pop('start_time', None)
         end_time = kwargs.pop('end_time', None)
-        converted_start_time = convert_datetime(start_time)
-        converted_end_time = convert_datetime(end_time)
+        converted_start_time = convert_datetime(start_time) if start_time else None
+        converted_end_time = convert_datetime(end_time) if end_time else None
         time_mode = kwargs.pop('time_mode', None)
         feedback_filter = MetricFeedbackFilter(
             metric_id=metric_id,

sdk/metricsadvisor/azure-ai-metricsadvisor/tests/test_helper_methods.py

@@ -25,7 +25,3 @@ def test_convert_datetime():
     input = datetime.datetime(2000, 1, 1)
     date_time = convert_datetime(input)
     assert date_time == datetime.datetime(2000, 1, 1)
-
-    input = None
-    date_time = convert_datetime(input)
-    assert date_time is None