Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

[AutoPR graphrbac/data-plane] graph: improve API coverage on application & service principal #4842

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/services/graphManagement/LICENSE.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2018 Microsoft
Copyright (c) 2019 Microsoft

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default class GraphRbacManagementClient extends AzureServiceClient {
users: operations.Users;
objects: operations.Objects;
domains: operations.Domains;
oAuth2: operations.OAuth2;
oAuth2PermissionGrantOperations: operations.OAuth2PermissionGrantOperations;
}

export { GraphRbacManagementClient, models as GraphRbacManagementModels };
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class GraphRbacManagementClient extends ServiceClient {
this.users = new operations.Users(this);
this.objects = new operations.Objects(this);
this.domains = new operations.Domains(this);
this.oAuth2 = new operations.OAuth2(this);
this.oAuth2PermissionGrantOperations = new operations.OAuth2PermissionGrantOperations(this);
this.models = models;
msRest.addSerializationMixin(this);
}
Expand Down
15 changes: 8 additions & 7 deletions lib/services/graphManagement/lib/models/aDGroup.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,14 @@ const models = require('./index');
class ADGroup extends models['DirectoryObject'] {
/**
* Create a ADGroup.
* @member {string} [displayName] The display name of the group.
* @member {boolean} [mailEnabled] Whether the group is mail-enabled. Must be
* false. This is because only pure security groups can be created using the
* Graph API.
* @member {string} [mailNickname] The mail alias for the group.
* @member {boolean} [securityEnabled] Whether the group is security-enable.
* @member {string} [mail] The primary email address of the group.
* @property {string} [displayName] The display name of the group.
* @property {boolean} [mailEnabled] Whether the group is mail-enabled. Must
* be false. This is because only pure security groups can be created using
* the Graph API.
* @property {string} [mailNickname] The mail alias for the group.
* @property {boolean} [securityEnabled] Whether the group is
* security-enable.
* @property {string} [mail] The primary email address of the group.
*/
constructor() {
super();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
class AddOwnerParameters {
/**
* Create a AddOwnerParameters.
* @member {string} url A owner object URL, such as
* @property {string} url A owner object URL, such as
* "https://graph.windows.net/0b1f9851-1bf0-433f-aec3-cb9272f093dc/directoryObjects/f260bbc4-c254-447b-94cf-293b5ec434dd",
* where "0b1f9851-1bf0-433f-aec3-cb9272f093dc" is the tenantId and
* "f260bbc4-c254-447b-94cf-293b5ec434dd" is the objectId of the owner (user,
Expand Down
18 changes: 9 additions & 9 deletions lib/services/graphManagement/lib/models/appRole.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,21 @@
class AppRole {
/**
* Create a AppRole.
* @member {string} [id] Unique role identifier inside the appRoles
* @property {string} [id] Unique role identifier inside the appRoles
* collection.
* @member {array} [allowedMemberTypes] Specifies whether this app role
* @property {array} [allowedMemberTypes] Specifies whether this app role
* definition can be assigned to users and groups by setting to 'User', or to
* other applications (that are accessing this application in daemon service
* scenarios) by setting to 'Application', or to both.
* @member {string} [description] Permission help text that appears in the
* @property {string} [description] Permission help text that appears in the
* admin app assignment and consent experiences.
* @member {string} [displayName] Display name for the permission that
* @property {string} [displayName] Display name for the permission that
* appears in the admin consent and app assignment experiences.
* @member {boolean} [isEnabled] When creating or updating a role definition,
* this must be set to true (which is the default). To delete a role, this
* must first be set to false. At that point, in a subsequent call, this role
* may be removed.
* @member {string} [value] Specifies the value of the roles claim that the
* @property {boolean} [isEnabled] When creating or updating a role
* definition, this must be set to true (which is the default). To delete a
* role, this must first be set to false. At that point, in a subsequent
* call, this role may be removed.
* @property {string} [value] Specifies the value of the roles claim that the
* application should expect in the authentication and access tokens.
*/
constructor() {
Expand Down
Loading