Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update operations for Azure AD administrator on MI. #8685

Merged
merged 4 commits into from
Nov 14, 2019

Conversation

SanjaMalesevic
Copy link
Contributor

This is a breaking change for .NET client. It brings managed instance admin API into sync with server admin API.
It is generated based on PR Azure/azure-rest-api-specs#7377

@SanjaMalesevic
Copy link
Contributor Author

Currently, I didn't add anything into section "New features:" from file Microsoft.Azure.Management.Sql.csproj. I am not sure what to add in case of updating existing client.
I've searched last few release notes and only found new features here.

@isra-fel isra-fel self-assigned this Nov 11, 2019
@isra-fel
Copy link
Member

Hi @SanjaMalesevic , could you

  • Add a link to the swagger spec review PR in the description
  • Include the .txt file generated when you run generate.ps1(details)
  • Since you are making a breaking change, please update the major version

Thanks

@isra-fel isra-fel assigned SanjaMalesevic and unassigned isra-fel Nov 11, 2019
@isra-fel isra-fel added the Mgmt This issue is related to a management-plane library. label Nov 12, 2019
@SanjaMalesevic
Copy link
Contributor Author

SanjaMalesevic commented Nov 13, 2019

Hi @isra-fel,

Here is the link to swagger spec PR Azure/azure-rest-api-specs#7377.
I've already included .txt file into CR (eng/mgmt/mgmtmetadata/sql_resource-manager.txt)
And, about major version, I've updated AssemblyVersion from 1.0.0.0 to 2.0.0.0 and according that version, I've also changed AssemblyFileVersion to 2.0.0-preview.

Thanks,
Sanja

- Added support for failover databases readable secondary.
]]>
</PackageReleaseNotes>
<PackageReleaseNotes>Operations Get, Create, Update and Delete from ManagedInstanceAdministratorsOperations have a different signature. Parameter "administratorName" is omitted.</PackageReleaseNotes>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap release notes with <![CDATA[ and ]]>, like it used to be. Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@isra-fel isra-fel merged commit 094b244 into Azure:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants