Style checking azure identity #7583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chidozieononiwu
requested review from
AlexGhiondea and
pakrym
as code owners
|
You did core changes here too |
chidozieononiwu
force-pushed
the
StyleCheckingAzureIdentity
branch
2 times, most recently
from
27372c5 to
46affad
Compare
I have removed all core related changes. |
schaabs
reviewed
Sep 12, 2019
|
|
||
| /// <summary> | ||
| /// Creates an instance with the specified <see cref="TokenCredential"/> sources. | ||
| /// </summary> | ||
| /// <param name="sources">The ordered chain of <see cref="TokenCredential"/> implementations to tried when calling <see cref="GetToken"/> or <see cref="GetTokenAsync"/></param> | ||
| public ChainedTokenCredential(params TokenCredential[] sources) | ||
| { | ||
| if (sources == null) throw new ArgumentNullException(nameof(sources)); | ||
| if (sources == null) | ||
| throw new ArgumentNullException(nameof(sources)); |
There was a problem hiding this comment.
Can we bracket these? I'm not a huge fan of having them on a new line without brackets.
There was a problem hiding this comment.
This rule csharp_preserve_single_line_statements = false is responsible for that. I have fixed up the current instances but it will likely happen again when new single line statements are introduced.
schaabs
reviewed
Sep 12, 2019
schaabs
reviewed
Sep 12, 2019
schaabs
reviewed
Sep 12, 2019
schaabs
approved these changes
Sep 12, 2019
chidozieononiwu
force-pushed
the
StyleCheckingAzureIdentity
branch
from
46affad to
396257f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable StyleCop and fix errors
Fix code style to adhere to editorconfig rules