-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable xml doc comments for our client libraries #6869
Conversation
b85d963
to
441e0cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Manually editing the generated code is not ideal. Can we just exclude /Generated/*RestClient.cs for now? All of that's going to be blown over the next time we need to make any change. |
As part of enabling this a number of xml doc comments needed to be fixed or warnings temporarily disabled to get a clean build. Follow-up issues will be filed for each class of warnings that needed to be disabled.
441e0cc
to
4d2c06b
Compare
I don't know of any good way to skip those files as they generate errors and not warnings as most of them are invalid xml. The only option would be to disable xml doc generation completely which means no docs at all for those libraries. |
Alright, I'll front load that work. Heads up @pakrym that you'll need to avoid any of your renames requiring generator changes until I get this addressed. |
As part of enabling this a number of xml doc comments needed to be fixed or
warnings temporarily disabled to get a clean build. Follow-up issues will
be filed for each class of warnings that needed to be disabled.
PTAL @AlexGhiondea @chidozieononiwu @tg-msft @pakrym