Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming ConfigurationClientModelFactory to ConfigurationModelFactory #6739

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Renaming ConfigurationClientModelFactory to ConfigurationModelFactory #6739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a079d5
renaming
maririos Jun 27, 2019
8f4c521
update readme
maririos Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/appconfiguration/Azure.ApplicationModel.Configuration/samples/Sample8_MockClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public void MockClient()
var mock = new Mock<ConfigurationClient>();
// Setup client method
mock.Setup(c => c.Get("Key", It.IsAny<string>(), It.IsAny<DateTimeOffset>(), It.IsAny<CancellationToken>()))
.Returns(new Response<ConfigurationSetting>(mockResponse.Object, ConfigurationClientModelFactory.ConfigurationSetting("Key", "Value")));
.Returns(new Response<ConfigurationSetting>(mockResponse.Object, ConfigurationModelFactory.ConfigurationSetting("Key", "Value")));

// Use the client mock
ConfigurationClient client = mock.Object;
Expand Down
2 changes: 1 addition & 1 deletion ...configuration/Azure.ApplicationModel.Configuration/src/ConfigurationClientModelFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Azure.ApplicationModel.Configuration
{
public static class ConfigurationClientModelFactory
public static class ConfigurationModelFactory
{
public static ConfigurationSetting ConfigurationSetting(
string key,
Expand Down
4 changes: 2 additions & 2 deletions sdk/core/Azure.Core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ Mocking is enabled by:

- providing a protected parameterless constructor on client types.
- making service methods virtual.
- providing APIs for constructing model types returned from virtual service methods. To find these factory methods look for types with the _ModelFactory_ suffix, e.g. `ConfigurationClientModelFactory`.
- providing APIs for constructing model types returned from virtual service methods. To find these factory methods look for types with the _ModelFactory_ suffix, e.g. `ConfigurationModelFactory`.

For example, the ConfigurationClient.Get method can be mocked (with [Moq](https://github.com/moq/moq4)) as follows:

Expand All @@ -122,7 +122,7 @@ mock.Setup(c =>
c.Get("Key", It.IsAny<string>(), It.IsAny<DateTimeOffset>(), It.IsAny<CancellationToken>()))
.Returns(new Response<ConfigurationSetting>(mockResponse.Object,
// factory for the model type
ConfigurationClientModelFactory.ConfigurationSetting("Key", "Value")
ConfigurationModelFactory.ConfigurationSetting("Key", "Value")
)
);

Expand Down