Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to R4 RP standard #6154

Merged
merged 2 commits into from
May 7, 2019
Merged

Update to R4 RP standard #6154

merged 2 commits into from
May 7, 2019

Conversation

leonardbf
Copy link
Contributor

@leonardbf leonardbf commented May 6, 2019

Correction to swagger error handler.
Addition of volume create from snapshot in swagger.
Removal of volume id as required parameter in snapshot creation.
Swagger PR Azure/azure-rest-api-specs#5683
Internal ticket NFSAAS-2317

@leonardbf
Copy link
Contributor Author

There is a validation pipeline failure which does not appear to be related to the PR changes. See https://dev.azure.com/azure-sdk/public/_build/results?buildId=27029. Some input on this would be useful. Thanks.

@dsgouda
Copy link
Contributor

dsgouda commented May 7, 2019

@weshaggard Please take a look at the failing test cases

@leonardbf
Copy link
Contributor Author

Added swagger PR (Azure/azure-rest-api-specs#5683) in the description.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI passes

@weshaggard
Copy link
Member

Known flaky test. See #6056.

@dsgouda dsgouda merged commit fcca8f5 into Azure:master May 7, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants