MPG migration - SecretsStoreExtension #54244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
mzhongl524
requested review from
cjoprey and
locomotiveviaduct
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Azure.ResourceManager.SecretsStoreExtension SDK to use the new code generator from TypeSpec (TSP) instead of the legacy emitter. The changes are primarily generated code updates that reflect the new generator's patterns and conventions.
Key changes:
- Switch from legacy emitter to new TSP-based code generator (azure-typespec-http-client-csharp-mgmt-emitter)
- Update parameter names from
serializedAdditionalRawDatatoadditionalBinaryDataProperties - Change subscription ID type from
stringtoGuidin REST operations - Modernize code patterns (explicit types instead of
var, updated documentation format)
Reviewed changes
Copilot reviewed 4 out of 78 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Updates emitter package reference and commit hash for new generator |
| SecretSyncTests.cs | Updates parameter name in test to match new generator output |
| SecretSyncResource.cs | Regenerated with new patterns: Guid subscription IDs, updated REST client usage, explicit types |
| SecretSyncResource.Serialization.cs | Updated serialization patterns with new naming conventions |
| SecretSyncData.cs | Simplified constructors and updated property documentation |
| SecretSyncData.Serialization.cs | Modernized serialization with protected methods and explicit types |
| SecretSyncCollection.cs | Updated to use new REST client patterns and Guid subscription IDs |
| RestOperations/* | Simplified to method factories returning HttpMessage instead of full request/response handling |
| Models/* | Consistent updates to serialization patterns, documentation, and naming conventions |
| ProviderConstants.cs | Added XML documentation |
| Utf8JsonRequestContent.cs | Added XML documentation for public members |
haiyuazhang
reviewed
Dec 12, 2025
sdk/secretsstoreextension/Azure.ResourceManager.SecretsStoreExtension/tsp-location.yaml
Outdated
Show resolved
Hide resolved
Member
|
please remove autorest.csharp dependency |
haiyuazhang
changed the title
live1206
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #53897
TSP PR: Azure/azure-rest-api-specs#39024
Use the new code generator to generate SDK code from TSP.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.