-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bug fix to recovery services backup #5202
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How was this code generated. Even if it is changes to minor fields, they must be fixed in the swagger spec first and the code has to be regenerated. Please link the swagger spec changes' PR
...Backup/Management.RecoveryServices.Backup/Generated/Models/PreValidateEnableBackupRequest.cs
Show resolved
Hide resolved
Link to spec PR - Azure/azure-rest-api-specs#5133 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WIll merge once CIs pass |
@AdityaTulasi please join the azure org here to kick off the build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please regenerate the code using generate.ps1 script. This should generate changes to SdkInfo_*.cs and .txt files. Please commit these changes too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge when CIs pass
* Undoing an unintended removal of field * Incorporating PR feedback * Updating release notes * Updating release notes * Fixing csproj file * Generating files using generate.ps1 file
Undoing unintended removal of a field in two classes