Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor bug fix to recovery services backup #5202

Merged
merged 7 commits into from
Feb 4, 2019
Merged

Minor bug fix to recovery services backup #5202

merged 7 commits into from
Feb 4, 2019

Conversation

AdityaTulasi-xx
Copy link
Contributor

Undoing unintended removal of a field in two classes

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

dsgouda
dsgouda suggested changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this code generated. Even if it is changes to minor fields, they must be fixed in the swagger spec first and the code has to be regenerated. Please link the swagger spec changes' PR

...Backup/Management.RecoveryServices.Backup/Generated/Models/PreValidateEnableBackupRequest.cs Show resolved Hide resolved
@AdityaTulasi-xx
Copy link
Contributor Author 

      How was this code generated. Even if it is changes to minor fields, they must be fixed in the swagger spec first and the code has to be regenerated. Please link the swagger spec changes' PR

Link to spec PR - Azure/azure-rest-api-specs#5133

dsgouda
dsgouda approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Feb 1, 2019

WIll merge once CIs pass

@dsgouda
Copy link
Contributor

dsgouda commented Feb 1, 2019

@AdityaTulasi please join the azure org here to kick off the build

@dsgouda dsgouda closed this Feb 4, 2019
@dsgouda dsgouda reopened this Feb 4, 2019
dsgouda
dsgouda suggested changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate the code using generate.ps1 script. This should generate changes to SdkInfo_*.cs and .txt files. Please commit these changes too.

dsgouda
dsgouda approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when CIs pass

@dsgouda dsgouda merged commit 3f95313 into Azure:master Feb 4, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@AdityaTulasi-xx @mentat9
Minor bug fix to recovery services backup (Azure#5202)
467d868 
* Undoing an unintended removal of field

* Incorporating PR feedback

* Updating release notes

* Updating release notes

* Fixing csproj file

* Generating files using generate.ps1 file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdityaTulasi-xx @azuresdkci @dsgouda @AditTulasi @shahabhijeet