-
Notifications
You must be signed in to change notification settings - Fork 5k
Updated the request header sent to the OIDC endpoint so it doesn't result in a redirect response when an invalid system access token is provided. #46135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
result in a redirect response when an invalid system access token is provided.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
API change check API changes are not detected in this pull request. |
sdk/identity/Azure.Identity/tests/AzurePipelinesCredentialLiveTests.cs
Outdated
Show resolved
Hide resolved
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
/azp run net - identity - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
@christothes I keep seeing a seemingly unrelated test fail on Ubuntu: Is this a known issue? It fails on identity test runs outside this PR, which makes me believe it isn't related to it. Please let me know if you'd like me to file a tracking issue for it (or optionally disable the test).
From analytics, this particular test has failed intermittently over the last few weeks: |
Yes, let's file a tracking issue. I think this is just a timing related issue since we are using the OIDC token that was set at the begining of the pipeline and sometimes we just happen to execute those tests after the 10 minute lifetime expiration. I have some ideas for how to resolve it that we can discuss in the issue. We can Ignore the test in the meantime, if it is blocking now consistently, and cite the issue in the reason. |
Done #46209 |
Fixes #46130