New Release of Automation SDK #4521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vrdmr please link the related REST spec |
|
@dsgouda - Added links to the Spec changes. |
dsgouda
suggested changes
Jul 2, 2018
| @@ -220,7 +220,7 @@ internal ScheduleOperations(AutomationClient client) | |||
| System.Net.HttpStatusCode _statusCode = _httpResponse.StatusCode; | |||
| cancellationToken.ThrowIfCancellationRequested(); | |||
| string _responseContent = null; | |||
| if ((int)_statusCode != 200 && (int)_statusCode != 409) | |||
| if ((int)_statusCode != 200 && (int)_statusCode != 201 && (int)_statusCode != 409) | |||
There was a problem hiding this comment.
@vrdmr Just to make sure, you are treating a 409 as a successful return code here?
There was a problem hiding this comment.
oh. Good catch. Fixing this in the spec.
| /// </summary> | ||
| IWatcherOperations Watcher { get; } | ||
| INodeCountInformationOperations NodeCountInformation { get; } |
There was a problem hiding this comment.
This is a breaking change. This will need a minor version bump in the csproj (3.2.0-preview)
|
@vrdmr Please open a new PR once you fix the REST spec and regenerate the code. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contains minor bigfixes and new resource - DscNodeCounts
Rest specs links:
Azure/azure-rest-api-specs#3190
Azure/azure-rest-api-specs#3304
Azure/azure-rest-api-specs#3327
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.