Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize RPC tags and select correct activity type #44906

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Recognize RPC tags and select correct activity type #44906

wants to merge 5 commits into from

Conversation

rvanheest
Copy link
Contributor

Fixes #44905

Select the RPC activity type in ActivityTagsProcessor such that Azure.Monitor.OpenTelemetry.Exporter.Models.RemoteDependencyData.SetRpcDependencyProperties will export the correct tags to ApplicationInsights.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter labels Jul 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Thank you for your contribution @rvanheest! We will review the pull request and get back to you soon.

TimothyMothra
TimothyMothra requested changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@TimothyMothra TimothyMothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation looks good, but I have to block this PR until the spec is stabalized.

https://github.com/open-telemetry/semantic-conventions/blob/main/docs/rpc/rpc-spans.md#client-attributes

@github-actions GitHub Actions
Copy link

Hi @rvanheest. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Sep 13, 2024
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Sep 13, 2024
@github-actions GitHub Actions
Copy link

Hi @rvanheest. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Nov 15, 2024
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Nov 15, 2024
@github-actions GitHub Actions
Copy link

Hi @rvanheest. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Jan 17, 2025
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyMothra TimothyMothra TimothyMothra requested changes

@cijothomas cijothomas Awaiting requested review from cijothomas

@reyang reyang Awaiting requested review from reyang

@rajkumar-rangaraj rajkumar-rangaraj Awaiting requested review from rajkumar-rangaraj rajkumar-rangaraj is a code owner

@vishweshbankwar vishweshbankwar Awaiting requested review from vishweshbankwar

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] OpenTelemetry tags for RPC are not associated with the correct OperationType
2 participants
@rvanheest @TimothyMothra