Adding POST APIs used to Upload customer TDE certificates in CMS. #4461
Conversation
| @@ -13,6 +13,7 @@ | |||
| <
There was a problem hiding this comment.
I published 1.17 today (on request from vulnerability assessment team), so now you need to bump this up to 1.18 and wipe out the old release notes (i.e. just line 15)
There was a problem hiding this comment.
Bump to 1.18 both in this file and in AssemblyInfo.cs
| GitHub fork: Azure | ||
| Branch: master | ||
| Commit: 69592a62dd01225f16a9b398664c3b9d6ddc8268 | ||
| GitHub fork: nivimsft |
There was a problem hiding this comment.
You will need to generate from Azure/master before this PR can be merged
There was a problem hiding this comment.
Sounds good! Waiting for PR to be merged
| // Update with values from a current MI on the region | ||
| // | ||
| string resourceGroup = ManagedInstanceResourceGroup; | ||
| string managedInstanceName = ManagedInstanceName; |
There was a problem hiding this comment.
Tests MUST be fully automated. This means that they must create all prerequisite resources during test setup. If this is not possible, the test must be skipped (see geo restore scenario test for example)
There was a problem hiding this comment.
Okay, automatic provisioning of Managed instances is not currently possible. Managed instances team is working on this. I will go ahead and skip these tests for now
Commit contains appropriate tests
- Updating version to 1.18 in .csproj and assemblyInfo - regenerate client from Azure/Master, - skipping tests with long setup time
|
Will merge when CIs pass |
| - Added support for using sever level Threat Detection. | ||
| - Enable customers to upload their TDE certificate to CMS |
There was a problem hiding this comment.
Customers do not know what CMS is. This release note should be more like, "Added support for uploading TDE certificate into servers and managed instances."
There was a problem hiding this comment.
You are right, will address
|
Thanks, now it's perfect! |
|
I like that, thanks for your help in making it so! :) |
Commit contains appropriate tests
Description
Adding POST APIs used to Upload customer TDE certificates in CMS code and tests
PR for spec changes Azure/azure-rest-api-specs#3248
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.