-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype of JsonModel<T> abstract class #43571
Conversation
@@ -107,6 +107,10 @@ public partial class HttpClientPipelineTransport : System.ClientModel.Primitives | |||
protected sealed override void ProcessCore(System.ClientModel.Primitives.PipelineMessage message) { } | |||
protected sealed override System.Threading.Tasks.ValueTask ProcessCoreAsync(System.ClientModel.Primitives.PipelineMessage message) { throw null; } | |||
} | |||
public partial interface IJsonModel | |||
{ | |||
System.Collections.Generic.IDictionary<string, object> AdditionalProperties { get; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be appropriate that we call it AdditionalProperties
?
A generated model in our current generated libraries might have AdditionalProperties
property if this is defined in the spec, and its type is usually IDictionary<string, BinaryData>
or IReadOnlyDictionary<string, BinaryData>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good point, and this is currently an open question under discussion - whether we should merge this feature with the existing AdditionalProperties feature. It is currently unclear whether we would want multiple property dictionaries on a type -- it sounds like we would prefer a single dictionary that supported both/all three cases (with _serializedAdditionalRawData as well), but the details of how this would work have not been finalized.
Hi @annelo-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hi @annelo-msft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
No description provided.