Disable self-logging and self-tracing in Azure Monitor distro, exporter, and livemetrics

[lmolkova]

Fixes #43286

In fact it's already fixed with #41858, this change prevents traces/logs creation from happening from LiveMetrics, Exporter or Distro, i.e. serves as a small optimization.

It changes the default - disables diagnostics, but in theory users can still enable if it's ever necessary to diagnose AzMon issues.

[TimothyMothra]

In fact it's already fixed with #41858,

Hmmm, that doesn't appear to be the case. I validated the open issue against the current main branch.

[lmolkova]

In fact it's already fixed with #41858,

Hmmm, that doesn't appear to be the case. I validated the open issue against the current main branch.

Did you see them in console or in the AppInsights resource?
Based on the test I wrote, OTel logger blocks any logs under suppressed scope here
https://github.com/open-telemetry/opentelemetry-dotnet/blob/876e4faa5aac56f456b52e4fbca965ce0e7b9b13/src/OpenTelemetry/Logs/ILogger/OpenTelemetryLogger.cs#L113

and nothing goes to the backend. Console/other provides logs will appear though.

This change also blocks console/other providers from ever seeing exporter/live metrics logs/traces

[TimothyMothra]

In fact it's already fixed with #41858,

Hmmm, that doesn't appear to be the case. I validated the open issue against the current main branch.

Did you see them in console or in the AppInsights resource? Based on the test I wrote, OTel logger blocks any logs under suppressed scope here https://github.com/open-telemetry/opentelemetry-dotnet/blob/876e4faa5aac56f456b52e4fbca965ce0e7b9b13/src/OpenTelemetry/Logs/ILogger/OpenTelemetryLogger.cs#L113

and nothing goes to the backend. Console/other provides logs will appear though.

This change also blocks console/other providers from ever seeing exporter/live metrics logs/traces

Ah, I was only testing the local console as this was the user's first complaint.

[TimothyMothra]

(not for this pr)
Do you think it's worth introducing a flag to allow users to opt-out of the LogForwarder?
I'm concerned about the volume of logs that may be collected.
I understand that a user can opt-out of the individual log sources.
But what can we offer a user that gets tired of playing whack-a-mole with their logs? :)

[lmolkova]

Do you think it's worth introducing a flag to allow users to opt-out of the LogForwarder?
I'm concerned about the volume of logs that may be collected.
I understand that a user can opt-out of the individual log sources.
But what can we offer a user that gets tired of playing whack-a-mole with their logs? :)

I'm totally open to add it in this or other PR, but users can easily disable all Azure logs by doing

  "Logging" : {
    "LogLevel" : {"Azure" : "None"}
  }

and extra API flag would just do the same, but introduce some conflicts (e.g. appsetting.json says it's enabled and flag disables it - it'd be harder to debug)

[TimothyMothra]

I'm totally open to add it in this or other PR, but users can easily disable all Azure logs by doing

Thanks. I think we can skip for now and continue to monitor user feedback.

For now, I think we should include a mention in the Distro Readme describing where these extra logs are coming from and how to opt-out. I can make an attempt at this.

[rajkumar-rangaraj]

LGTM

[cijothomas]

I'm totally open to add it in this or other PR, but users can easily disable all Azure logs by doing

Thanks. I think we can skip for now and continue to monitor user feedback.

For now, I think we should include a mention in the Distro Readme describing where these extra logs are coming from and how to opt-out. I can make an attempt at this.

Agree!
If ILogger's filtering can be used to control this already, then its best not to introduce another setting in distro.